Variables should not be initialized to defaults (uint256 default is 0): GolomTrader.sol::415 => for (uint256 i = 0; i < proof.length; i++) { RewardDistributor.sol::142 => uint256 reward = 0; RewardDistributor.sol::143 => for (uint256 index = 0; index < epochs.length; index++) { RewardDistributor.sol::156 => uint256 reward = 0; RewardDistributor.sol::157 => for (uint256 index = 0; index < epochs.length; index++) { RewardDistributor.sol::175 => uint256 reward = 0; RewardDistributor.sol::176 => uint256 rewardEth = 0; RewardDistributor.sol::180 => for (uint256 tindex = 0; tindex < tokenids.length; tindex++) { RewardDistributor.sol::183 => for (uint256 index = 0; index < epochs.length; index++) { RewardDistributor.sol::222 => uint256 reward = 0; RewardDistributor.sol::223 => uint256 rewardEth = 0; RewardDistributor.sol::226 => for (uint256 index = 0; index < epoch; index++) { RewardDistributor.sol::257 => uint256 reward = 0; RewardDistributor.sol::258 => for (uint256 index = 0; index < epoch; index++) { RewardDistributor.sol::272 => uint256 reward = 0; RewardDistributor.sol::273 => for (uint256 index = 0; index < epoch; index++) { VoteEscrowCore.sol::745 => for (uint256 i = 0; i < 255; ++i) { VoteEscrowCore.sol::1044 => for (uint256 i = 0; i < 128; ++i) { VoteEscrowCore.sol::1115 => for (uint256 i = 0; i < 128; ++i) { VoteEscrowCore.sol::1167 => for (uint256 i = 0; i < 255; ++i) { VoteEscrowCore.sol::1211 => uint256 dt = 0; VoteEscrowDelegation.sol::147 => uint256 lower = 0; VoteEscrowDelegation.sol::170 => uint256 votes = 0; VoteEscrowDelegation.sol::171 => for (uint256 index = 0; index < delegated.length; index++) { VoteEscrowDelegation.sol::188 => uint256 votes = 0; VoteEscrowDelegation.sol::189 => for (uint256 index = 0; index < delegatednft.length; index++) { Length of array should be computed outside of for-loop: GolomTrader.sol::415 => for (uint256 i = 0; i < proof.length; i++) { RewardDistributor.sol::143 => for (uint256 index = 0; index < epochs.length; index++) { RewardDistributor.sol::157 => for (uint256 index = 0; index < epochs.length; index++) { RewardDistributor.sol::180 => for (uint256 tindex = 0; tindex < tokenids.length; tindex++) { RewardDistributor.sol::183 => for (uint256 index = 0; index < epochs.length; index++) { TokenUriHelper.sol::13 => uint256 len = data.length; VoteEscrowCore.sol::607 => if (reason.length == 0) { VoteEscrowDelegation.sol::99 => require(_delegatedTokenIds.length < 500, 'VVDelegation: Cannot stake more'); VoteEscrowDelegation.sol::171 => for (uint256 index = 0; index < delegated.length; index++) { VoteEscrowDelegation.sol::189 => for (uint256 index = 0; index < delegatednft.length; index++) { VoteEscrowDelegation.sol::199 => for (uint256 i; i < _array.length; i++) { VoteEscrowDelegation.sol::201 => _array[i] = _array[_array.length - 1]; != is more efficient than > 0 for uint comparisons: GolomTrader.sol::152 => if (payAmt > 0) { GolomTrader.sol::250 => if (o.refererrAmt > 0 && referrer != address(0)) { GolomTrader.sol::387 => if (o.refererrAmt > 0 && referrer != address(0)) { RewardDistributor.sol::124 => if (previousEpochFee > 0) { VoteEscrowCore.sol::579 => return size > 0; VoteEscrowCore.sol::704 => if (old_locked.end > block.timestamp && old_locked.amount > 0) { VoteEscrowCore.sol::708 => if (new_locked.end > block.timestamp && new_locked.amount > 0) { VoteEscrowCore.sol::727 => if (_epoch > 0) { VoteEscrowCore.sol::855 => // value == 0 (extend lock) or value > 0 (add to lock or extend lock) VoteEscrowCore.sol::927 => require(_value > 0); // dev: need non-zero value VoteEscrowCore.sol::928 => require(_locked.amount > 0, 'No existing lock found'); VoteEscrowCore.sol::944 => require(_value > 0); // dev: need non-zero value VoteEscrowCore.sol::981 => assert(_value > 0); // dev: need non-zero value VoteEscrowCore.sol::982 => require(_locked.amount > 0, 'No existing lock found'); VoteEscrowCore.sol::997 => require(_locked.amount > 0, 'Nothing is locked'); VoteEscrowDelegation.sol::78 => if (nCheckpoints > 0) { VoteEscrowDelegation.sol::103 => if (nCheckpoints > 0 && oldCheckpoint.fromBlock == block.number) { VoteEscrowDelegation.sol::119 => return nCheckpoints > 0 ? checkpoints[tokenId][nCheckpoints - 1].delegatedTokenIds : myArray; Shortening revert strings to 32 bytes can decrease gas costs: TokenUriHelper.sol::72 TokenUriHelper.sol::76 TokenUriHelper.sol::78 TokenUriHelper.sol::84 TokenUriHelper.sol::86 TokenUriHelper.sol::92 TokenUriHelper.sol::94 TokenUriHelper.sol::100 TokenUriHelper.sol::102 TokenUriHelper.sol::112 VoteEscrowCore.sol::589 VoteEscrowCore.sol::625 Switching from division/multiplication to right-shift/left-shift can save gas: TokenUriHelper.sol::72 VoteEscrowCore.sol::296 => uint256 internal constant MAXTIME = 4 * 365 * 86400; VoteEscrowCore.sol::297 => int128 internal constant iMAXTIME = 4 * 365 * 86400; VoteEscrowCore.sol::1049 => uint256 _mid = (_min + _max + 1) / 2; VoteEscrowCore.sol::1120 => uint256 _mid = (_min + _max + 1) / 2; VoteEscrowDelegation.sol::150 => uint256 center = upper - (upper - lower) / 2; // ceil, avoiding overflow VoteEscrowDelegation.sol::199 => In the `removeElement` for-loop, instead of `i++` use unchecked `{++i}` in the body of the loop to save on overflow checks. We know there is a limit of 500 on `delegatedTokenIds` and that's all the `removeElement` function is ever used on. Additionally, the _element and i (index) variables can be declared as `uint16` since we know there is a limit of 500 on the size of `delegatedTokenIds`. GolomTrader::415 => The for-loop in `_verifyProof` can be more gas efficient by incrementing via `++i`.


Code4rena	Golom contest	Golom	26/07/2022	01/08/2022	6 days	$75,000 USDC	64/179	$181.06	5	2	0	1	0	-	-	0	Completed
Code4rena	Juicebox V2 contest	Juicebox	01/07/2022	08/07/2022	7 days	$75,000 USDC	102/105	$14.87	1	1	0	0	0	0	0	0	Completed

Green