Platform: Code4rena
Start Date: 09/07/2021
Pot Size: $25,000 USDC
Total HM: 7
Participants: 10
Period: 3 days
Judge: ghoulsol
Total Solo HM: 2
Id: 19
League: ETH
Rank: 10/10
Findings: 2
Award: $29.52
🌟 Selected for report: 0
🚀 Solo Findings: 0
29.5216 USDC - $29.52
greiart
https://github.com/code-423n4/2021-07-connext/blob/main/contracts/TransactionManager.sol#L254-L257
https://github.com/code-423n4/2021-07-connext/blob/main/contracts/TransactionManager.sol#L260
Since sol version 0.8.4 is used which contains native integer flow checks, the liquidity decrement (L260) will revert should there be insufficient liquidity. This makes the check in L254-L257 redundant, thought this comes at the expense of a slight increase in ambiguity of failed transactions.
Remove lines 254-257.
https://www.notion.so/3596a7cd39334e339bfc293b8cab55f7?v=4f71f7e35f5f486bb54e33f50b71dfb4
#0 - LayneHaber
2021-07-13T17:34:53Z
#74