FIAT DAO veFDT contest

FIAT DAO veFDT contest details

• $33,250 USDC main award pot
• $1,750 USDC gas optimization award pot
• Join C4 Discord to register
• Submit findings using the C4 form
• Read our guidelines for more details
• Starts August 12, 2022 20:00 UTC
• Ends August 15, 2022 20:00 UTC

Contracts

Scope

Files in scope

All other source contracts (not in scope)

External imports

• @openzeppelin/contracts/security/ReentrancyGuard.sol
  • contracts/VotingEscrow.sol

All-in-one command

export ALCHEMY_MAINNET_API_KEY=<your-api-key-goes-here> && rm -Rf 2022-08-fiatdao || true && git clone https://github.com/code-423n4/2022-08-fiatdao && cd 2022-08-fiatdao && npm install && npm run build && npm run test

veFDT

A solidity implementation of Curve's voting-escrow with additional features outlined below.

Lock delegation Users may delegate ther lock to another user whereby they give the delegatee control over their lock expiration and balance (i.e. voting power). Both users, the delegator and the delegatee, need to have an active lock in place at the time of delegation. Moreover, the delegatee's lock expiration needs to be longer than the delegator's.

Lock quitting A non-expired lock may be quitted by the lock owner anytime. The lock cannot be delegated at the time of quitting and the quitter pays a penalty proportional to the remaining lock duration.

Optimistic SmartWallet approval SmartWallets (i.e. contracts) can create a lock without being approved first. However, the veFDT owner maintains a Blocklist where SmartWallets may be blocked from further interacting with the system. The Blocklist only allows the owner to block contracts but not EOAs. Blocked SmartWallets may still undelegate (if delegated prior to the blocking) and quit their lock (by paying the penalty) or withdraw once the lock expired.

🏄 Quickstart

npm install

npm run build

npm run test

Note: We use hardhat and Alchemy web3 provider in order to test against Ethereum mainnet state. Make sure to configure an Alchemy API endpoint with a valid key before running the test script:

export ALCHEMY_MAINNET_API_KEY=[ALCHEMY_KEY]

Voting-escrow math

The veFDT contract implements the same checkpoint mathematics than the original Curve VotingEscrow.vy contract. The new features leverage this math in order to void or redirect (i.e. delegate) a lock's virtual balance. More details about how the various lock operations interact with Curve's checkpoint math can be found here.

Source

• Curve Finance: Original concept and implementation in Vyper (Source)
• mStable: Forking Curve's Vyper contract and porting to Solidity including math tests (Source)

Scope Q/A

• Do you have a link to the repo that the contest will cover? https://github.com/fiatdao/veFDT (private repo)
• How many (non-library) contracts are in the scope? 5
• Total sLoC in these contracts? 746
• How many library dependencies? 1
• How many separate interfaces and struct definitions are there for the contracts within scope? 3
• Does most of your code generally use composition or inheritance? no
• How many external calls? 1
• Is there a need to understand a separate part of the codebase / get context in order to audit this part of the protocol? false
• Does it use an oracle? false
• Does the token conform to the ERC20 standard? no token
• Are there any novel or unique curve logic or mathematical models? yes
• Does it use a timelock function? yes
• Is it an NFT? no
• Does it have an AMM? no
• Is it a fork of a popular project? true
• If yes, please describe your customisations: Curve VotingEscrow.vy contract translated to solidity and with delegation, quit-lock features added
• Does it use rollups? false
• Is it multi-chain? false
• Does it use a side-chain? false
• Do you have a preferred timezone for communication? CET