A CDP-backed stablecoin platform designed to generate yield on underlying assets to establish a sustainable DeFi stable interest rate.
Platform: Code4rena
Start Date: 16/02/2023
End Date: 07/03/2023
Period: 19 days
Status: Completed
Pot Size: $144,750 USDC
Participants: 154
Reporter: liveactionllama
Judge: Trust
Id: 216
League: ETH
hansfriese | 1/154 | $13,062.09 | 5 | 1 | 0 | 3 | 2 | Grade B | 0 | 0 |
0xBeirao | 2/154 | $11,668.80 | 3 | 2 | 0 | 1 | 0 | 0 | 0 | 0 |
GalloDaSballo | 3/154 | $11,609.81 | 6 | 0 | 0 | 4 | 1 | Grade A | Grade A | 0 |
bin2chen | 4/154 | $9,600.63 | 4 | 1 | 0 | 2 | 0 | Grade B | 0 | 0 |
gjaldon | 5/154 | $9,417.93 | 2 | 1 | 0 | 1 | 1 | 0 | 0 | 0 |
peritoflores | 6/154 | $5,858.74 | 1 | 0 | 0 | 1 | 1 | 0 | 0 | 0 |
rbserver | 7/154 | $4,511.53 | 3 | 0 | 0 | 2 | 0 | Grade A | 0 | 0 |
hyh | 8/154 | $4,281.76 | 3 | 2 | 0 | 0 | 0 | - | 0 | 0 |
chaduke | 9/154 | $3,838.19 | 3 | 1 | 0 | 1 | 0 | Grade B | 0 | 0 |
koxuan | 10/154 | $3,838.19 | 3 | 1 | 0 | 1 | 0 | - | 0 | 0 |
Auditor per page
Automated findings output for the Ethos-Core package can be found here.
Automated findings output for the Ethos-Vault package can be found here.
Automated findings output for the contest can be found here within an hour of contest opening.
If you're looking for a head start, we recommend that you compare Ethos-Core's slither output above to Liquity's here.
You can find a video walkthrough of the repository here.
An overview of the codebase can be found here.
A relatively simple explanation of the system can be found here.
You can find definitions for all the terms used in the system here.
A table describing liquidations under different contexts can be found here.
Please familiarize yourself with the following acronyms...
Individual collateralization ratio (ICR): a Trove's ICR is the ratio of the dollar value of its entire collateral at the current ETH:USD price, to its entire debt.
Nominal collateralization ratio (nominal ICR, NICR): a Trove's nominal ICR is its entire collateral (in ETH) multiplied by 100e18 and divided by its entire debt.
Total collateralization ratio (TCR): the ratio of the dollar value of the entire system collateral at the current ETH:USD price, to the entire system debt.
Critical collateralization ratio (CCR): When the TCR is below the CCR, the system enters Recovery Mode.
...and then gain an understanding of different liquidation contexts here
A link to the live version of Ethos Reserve will be provided on Discord during the contest.
Many Ethos contracts utilize external calls to execute their business logic, but these calls are primarily sent to other contracts WITHIN the system and access control is tested thoroughly, so we don't include them in the external calls column.
Additionally, you will find there is a lot of code in the app that we don't include in our scope - this is because the codebase we built on is heavily battle tested, we haven't made risky changes to those contracts, and we've tested these areas thoroughly. If bugs are found in contracts not listed in the table below, we are open to rewarding the auditor if the findings result in an implementation change, however the primary focus of auditors should be files below.
While some of these files might be good to add context for in-scope contracts, we won't be offering bounties for issues within them.
Ethos-Core/contracts/Dependencies/
Ethos-Core/contracts/Proxy/
Ethos-Core/contracts/TestContracts/
Ethos-Vault/contracts/mixins/
Ethos-Vault/contracts/libraries/
While we made broad changes to the Liquity codebase, the test suite has been updated to support them. We abided by their design patterns throughout, with the riskiest areas being the following:
Ethos-Core/contracts/ActivePool.sol, Ethos-Vault/contracts/ReaperVaultV2.solEthos-Core/contracts/LQTY/CommunityIssuance.sol, Ethos-Core/contracts/StabilityPool.sol- If you have a public code repo, please share it here: n/a - How many contracts are in scope?: 11 - Total SLoC for these contracts?: 3500 - How many external imports are there?: 40 - How many separate interfaces and struct definitions are there for the contracts within scope?: 30 - Does most of your code generally use composition or inheritance?: inheritance - How many external calls?: 3 - What is the overall line coverage percentage provided by your tests?: 93 - Is there a need to understand a separate part of the codebase / get context in order to audit this part of the protocol?: false - Please describe required context: - Does the token conform to the ERC20 standard?: yes - Are there any novel or unique curve logic or mathematical models?: It uses a curve to set the fee during high volume periods - Does it use an oracle?: Chainlink - Is it a fork or alternate implementation of another project? True; Liquity and Yearn V2 - Does it use a side-chain?: true - Describe any specific areas you would like addressed. E.g. Please try to break XYZ.: Would like users to try and break the asset management accounting, the liquidation logic, and the issuance and redemption logic
For each package (Ethos Core, Ethos-Vault), First clone the repository and install dependencies using:
npm install
In Ethos-Vault, add a .env file using either the dummy keys provided in .env.example or your own.
Run all tests with npx hardhat test, or run a specific test with npx hardhat test ./test/contractTest.js
To run a specific test in a file without running others, append the it method with .only like this:
it.only("name of test")
Hardhat will only run tests using the .only method in that file
There is a loss of precision in line 112 of CommunityIssuance.sol. Though we consider this out of the contest's scope, we are open to field arguments for implementation changes under the QA bucket of rewards.
We are aware that adding large amounts of collateral types could cause gas prices to increase and state updates to eventually fail. Our plan is to have only 2-5 collateral types in any given deployment. We may add a require statement to the CollateralConfig constructor down the line but consider this a known issue.
You can find known issues in the Liquity codebase here.