LI.FI contest - 0v3rf10w's results

l-01:

require statement is used after action/needed, put require above action AnyswapFacet.sol L#45

            LibAsset.transferFromERC20(underlyingToken, msg.sender, address(this), _anyswapData.amount);

            require(
                LibAsset.getOwnBalance(underlyingToken) - _fromTokenBalance == _anyswapData.amount,
                "ERR_INVALID_AMOUNT"
            );

require should be before transfer to check amount correctly Other places : CBridgeFacet.sol L#63

l-02:

removeDex() is using batchRemoveDex() logic which is irrelevant, either remove loop part of removeDex() or remove one of the functions

DexManagerFace.sol L#52-55, this loop is also used in batchRemoveDex() which is not logical

l-03:

require statement is missing in GenericSwapFacet.sol to check validity of postSwapBalance as used in other swapfacets

l-04:

!= is missing in if statement HopFacet.sol L#64 I think if (sendingAssetId == address(0)) should be if (sendingAssetId != address(0)) else it doesn't make sense

here too, NXTPFacet.sol L#52

g01:

floating pragma should not be used, prefer to fix it to 0.8.10

g02:

break && into two require statements to save gas AnyswapFacet.sol L#37, 80 Swapper.sol L#15

g03:

declaring functions external instead of public can save gas

g04:

use custom errors error() or try to use error codes/ shorten strings in require statements for saving gas similar to LibAsset.sol L#50

g05:

use uint256 instead of uint64,32,etc.. CBridgeFacet.sol L#21,30,32 HopFacet.sol L#48 Swapper.sol L#14

g06:

use calldata instead of memory to save gas AnyswapFacet.sol L#77,131 CBridgeFacet.sol L#95,142

g07:

use prefix instead of suffix to save gas, {++i} instead of i++ As all these functions are used a lot, hence in long run, gas saving are enough to be worth it DexManagerFacet.sol L#33,52,65 DiamondLoupeFacet.sol L#24 HopFacet.sol L#48 Swapper.sol L#14 LibDiamond.sol L#67,97

g08:

try to use immutable to save gas for fixed constants to save gas e.g. LibAsset.sol L#15,21 LibSwap.sol L#8

g09:

use != instead of > to save gas for uint as they can't be negative LibDiamond.sol L#102,121