Platform: Code4rena
Start Date: 29/03/2022
Pot Size: $30,000 USDC
Total HM: 6
Participants: 24
Period: 3 days
Judge: HardlyDifficult
Total Solo HM: 4
Id: 101
League: ETH
Rank: 15/24
Findings: 2
Award: $118.98
🌟 Selected for report: 0
🚀 Solo Findings: 0
79.9617 USDC - $79.96
consistently use safeTransfer instead of transfer
LenderPool.start(uint256,address) (PooledCreditLine/LenderPool.sol#312-330) ignores return value by IERC20(_borrowAsset).transfer(_to,_fee) (PooledCreditLine/LenderPool.sol#327)
Consider to use safeTransfer
#0 - ritik99
2022-04-12T19:57:01Z
Valid
39.0156 USDC - $39.02
lack of zero check
constructor(address _lenderPool, address _usdc) { lenderPool = _lenderPool; USDC = _usdc; }
pooledcreditline.sol L#592
can break && in require statements to seperate statements(two seperate require statements) to save gas
require(_request.borrowAsset != address(0) && _request.collateralAsset != address(0), 'R4')
to
require(_request.borrowAsset != address(0) , 'R4') require(_request.collateralAsset != address(0), 'R4')
pooledcreditline.sol L#642
#0 - ritik99
2022-04-12T19:05:46Z
Both suggestions are valid