Sublime contest - 0v3rf10w's results

Democratizing credit via Web3.

General Information

Platform: Code4rena

Start Date: 29/03/2022

Pot Size: $30,000 USDC

Total HM: 6

Participants: 24

Period: 3 days

Judge: HardlyDifficult

Total Solo HM: 4

Id: 101

League: ETH

Sublime

Findings Distribution

Researcher Performance

Rank: 15/24

Findings: 2

Award: $118.98

🌟 Selected for report: 0

🚀 Solo Findings: 0

Findings Information

Awards

79.9617 USDC - $79.96

Labels

bug
QA (Quality Assurance)

External Links

M-01:

consistently use safeTransfer instead of transfer

LenderPool.start(uint256,address) (PooledCreditLine/LenderPool.sol#312-330) ignores return value by IERC20(_borrowAsset).transfer(_to,_fee) (PooledCreditLine/LenderPool.sol#327)

Consider to use safeTransfer

#0 - ritik99

2022-04-12T19:57:01Z

Valid

Findings Information

Awards

39.0156 USDC - $39.02

Labels

bug
G (Gas Optimization)

External Links

L-01:

lack of zero check

constructor(address _lenderPool, address _usdc) { lenderPool = _lenderPool; USDC = _usdc; }

pooledcreditline.sol L#592

G-01:

can break && in require statements to seperate statements(two seperate require statements) to save gas

require(_request.borrowAsset != address(0) && _request.collateralAsset != address(0), 'R4')

to

require(_request.borrowAsset != address(0) , 'R4') require(_request.collateralAsset != address(0), 'R4')

pooledcreditline.sol L#642

#0 - ritik99

2022-04-12T19:05:46Z

Both suggestions are valid

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter