Backd contest - 0v3rf10w's results

QA1: zero address checks

lack of zero address checks -

StakerVault.sol l#66

    function initialize(address _token) external override initializer {
        token = _token;
    }

Vault.sol l#73-80

    constructor(IController _controller)
        Authorization(_controller.addressProvider().getRoleManager())
    {
        controller = _controller;
        IAddressProvider addressProvider_ = _controller.addressProvider();
        addressProvider = addressProvider_;
        reserve = IVaultReserve(addressProvider_.getVaultReserve());
    }

QA2 : Prefer SafeTransfer

l#291,692

...
       } else {
            staker.transfer(payer, position.depositTokenBalance); @audit
        }
...

l#692

...
            if (position.depositTokenBalance > 0) {
                // transfer any unused locked tokens to the payer
                IStakerVault(vault).transfer(payer, position.depositTokenBalance); @audit
                IStakerVault(vault).decreaseActionLockedBalance(
                    payer,
                    position.depositTokenBalance
                );
            }
...

consistently use safeTransfer instead of transfer

Gas :

contracts/actions/topup/TopUpAction.sol

• l#47,57 - prefer != instead of > for unisgned int (gas1)
• l#188,456,479,506,891 - prefix ++i should be used and no need to initialise i, best if unchecked() is used (gas2)
• l#180 - functions with access control like onlyGovernance can be marked payable to save gas (gas3)
• l#359,676 - can break && in require() into two seperate require which will be more gas efficient (gas4)

contracts/strategies/BkdTriHopCvx.sol

• l#358,364 - use != instead of > for unsigned int (gas1)

contracts/strategies/BkdEthCvx.sol

• l#100,106 - use != instead of > for unsigned int (gas1)

contracts/StakerVault.sol

• l#260, - prefix ++i should be used and no need to initialise i, best if unchecked() is used (gas2)
• l#324,331,338,339- in func stakeFor token can gas-golfed via mload, caching in memory rather than 3 loads --- Similarly for unstakeFor() (gas5)

contracts/actions/topup/TopUpKeeperHelper.sol

• l#43,46,72,93 - prefix ++i should be used and no need to initialise i, best if unchecked() is used (gas2)

contracts/strategies/ConvexStrategyBase.sol 276

• l#274 - can break && in require() into three seperate require which will be more gas efficient (gas4)
• l#313 - prefix ++i should be used and no need to initialise i, best if unchecked() is used (gas2)

contracts/vault/Vault.sol

• l#164,232,698 - use != instead of > for unsigned int (gas1)

contracts/pool/LiquidityPool.sol

• l#401,471,473 - use != instead of > for unsigned int (gas1)