Platform: Code4rena
Start Date: 15/02/2022
Pot Size: $30,000 USDC
Total HM: 18
Participants: 35
Period: 3 days
Judge: GalloDaSballo
Total Solo HM: 8
Id: 87
League: ETH
Rank: 29/35
Findings: 1
Award: $79.95
🌟 Selected for report: 0
🚀 Solo Findings: 0
79.9481 USDC - $79.95
BribeVault.sol, fee and feeDivisor has no effectThe global variable fee is never used. In transferBribes function as long as distributorAmount == 1 remaining tokens can be sent as fee to the feeRecipient. Therefore, current implementation is misleading in terms of describing fees and providing the functionality.
rewardForwarding is not implementedAlthough rewardForwarding is mentioned in README and the setter is implemented in TokemakBribe.sol. The functionality is not implemented.
TokemakBribe.sol#round is not strictly increasinground is not strictly increasing. From my understanding, this variable should be strictly increasing and preferably by one after each update.
#0 - kphed
2022-02-18T18:55:03Z
BribeVault.sol, fee and feeDivisor has no effect
Both variables will be used by an off-chain script when compiling the transferBribes call data. We are planning to add on-chain validation as well.
Functionality of rewardForwarding is not implemented
The mapping is checked when constructing the Merkle tree. We will also publish data showing information such as which account forwarded rewards.
TokemakBribe.sol#round is not strictly increasing
This is a planned change.
#1 - GalloDaSballo
2022-02-26T16:51:13Z
Findings are valid and severity is appropriate
#2 - GalloDaSballo
2022-02-27T00:22:16Z
4/10