Nibbl contest - 0xc0ffEE's results

NFT fractionalization protocol with guaranteed liquidity and price based buyout.

General Information

Platform: Code4rena

Start Date: 21/06/2022

Pot Size: $30,000 USDC

Total HM: 12

Participants: 96

Period: 3 days

Judge: HardlyDifficult

Total Solo HM: 5

Id: 140

League: ETH

Nibbl

Findings Distribution

Researcher Performance

Rank: 78/96

Findings: 1

Award: $28.28

🌟 Selected for report: 0

🚀 Solo Findings: 0

  1. https://github.com/NibblNFT/nibbl-smartcontracts/blob/49bf364d9e81a554cfdf47ae5cfc3daf52a54ad6/contracts/Twav/Twav.sol#L35-L42 Incorrect assignment for _twavObservationCurrent and _twavObservationPrev cause of incorrect index . This could lead to the calculation for _twav got underflowed as current cumulative valuation is greater than previous cumulative valuation and reverted
  2. Prevent funds locked forever by checking for recipient address is not address(0) in all functions that transfer funds, such as: buy, sell, redeem, redeemCuratorFee ,all the withdraw* functions and _newCurator in updateCurator
  3. There are some configurations mismatched with the documentation at url https://github.com/NibblNFT/nibbl-smartcontracts/blob/master/README.md : BUYOUT_DURATION = 5 days but the docs mentioned 3 days,
  4. Should use unchecked at https://github.com/NibblNFT/nibbl-smartcontracts/blob/49bf364d9e81a554cfdf47ae5cfc3daf52a54ad6/contracts/NibblVault.sol#L319 , https://github.com/NibblNFT/nibbl-smartcontracts/blob/49bf364d9e81a554cfdf47ae5cfc3daf52a54ad6/contracts/NibblVault.sol#L378-L383, https://github.com/NibblNFT/nibbl-smartcontracts/blob/49bf364d9e81a554cfdf47ae5cfc3daf52a54ad6/contracts/NibblVault.sol#L415

#0 - HardlyDifficult

2022-07-04T14:56:27Z

  1. Invalid, these are cumulative so the values always increase. 2 is a good suggestion. 4 could use a better explanation.
AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter