Lybra Finance - 0xhacksmithh's results

Lines of code

https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/governance/LybraGovernance.sol#L143-L145 https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/governance/LybraGovernance.sol#L147-L149

Vulnerability details

Impact

Returning wrong time value

Proof of Concept

These 2 functions returning 3second for votingPeriod and 1second for voatingDelay.

    function votingPeriod() public pure override returns (uint256){
         return 3; // @audit-issue
    }

     function votingDelay() public pure override returns (uint256){
         return 1; // @audit
    }

Tools Used

Manual Review

Recommended Mitigation Steps

Should re-check this

Assessed type

Context