Platform: Code4rena
Start Date: 13/12/2023
Pot Size: $36,500 USDC
Total HM: 18
Participants: 110
Period: 8 days
Judge: 0xTheC0der
Id: 311
League: ETH
Rank: 64/110
Findings: 1
Award: $44.03
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: osmanozdemir1
Also found by: 0xCiphky, 0xDING99YA, 0xlemon, 0xluckhu, AS, Abdessamed, BARW, KupiaSec, MrPotatoMagic, SovaSlava, SpicyMeatball, ast3ros, bart1e, hakymulla, ktg, n1punp, plasmablocks, shaka, twcctop
44.0266 USDC - $44.03
https://github.com/code-423n4/2023-12-revolutionprotocol/blob/d42cc62b873a1b2b44f57310f9d4bbfdd875e8d6/packages/revolution/src/ERC20TokenEmitter.sol#L180 https://github.com/code-423n4/2023-12-revolutionprotocol/blob/d42cc62b873a1b2b44f57310f9d4bbfdd875e8d6/packages/revolution/src/ERC20TokenEmitter.sol#L202
In ERC20TokenEmitter::buyToken(), when a buyToken purchase is made, a creatorRateBps portion of the proceeds is reserved for the creatorsAddress, with direct payment calculated according to the entropyRateBps.
Specially if entropyRateBps != 10_000, meaning there is remaining Ether from the reserve of the creatorsAddress, i.e., ((msgValueRemaining - toPayTreasury) - creatorDirectPayment) > 0. The remaining Ether is used to emit tokens to the creatorsAddress (line 180, 202). However, this part of Ether is not transferred out to a proper address (may be treasury?), thus it is locked in the ERC20TokenEmitter contract and no way to transfer it out (unless upgrade the contract).
NA
Manual
Transfer the remaining Ether (if any) used to emit tokens to creators to a proper address (treasury?).
ETH-Transfer
#0 - c4-pre-sort
2023-12-21T22:40:15Z
raymondfam marked the issue as sufficient quality report
#1 - c4-pre-sort
2023-12-21T22:40:34Z
raymondfam marked the issue as duplicate of #13
#2 - c4-pre-sort
2023-12-24T02:54:53Z
raymondfam marked the issue as duplicate of #406
#3 - c4-judge
2024-01-05T23:06:06Z
MarioPoneder marked the issue as satisfactory
#4 - c4-judge
2024-01-05T23:06:21Z
MarioPoneder changed the severity to 3 (High Risk)