Cally contest - ACai's results

Lines of code

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L258-L297

Vulnerability details

Impact

If the owner raise the fee to 100%, the ETH increment of currentBeneficiary in exercise function would be 0.

Proof of Concept

If the owner raise the fee before executing exercise function, the currentBeneficiary will suffer unexpected losses.

Tools Used

Recommended Mitigation Steps

1. Adding a element Vault.fee in Vault structure and setting the fee while creating the vault.
2. Set a fee range acceptable to users. (such as 0~5%)