Platform: Code4rena
Start Date: 23/05/2022
Pot Size: $50,000 USDC
Total HM: 44
Participants: 99
Period: 5 days
Judge: hickuphh3
Total Solo HM: 11
Id: 129
League: ETH
Rank: 77/99
Findings: 2
Award: $68.24
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: cccz
Also found by: AlleyCat, GimelSec, IllIllI, Ruhum, berndartmueller, csanuragjain, dipp, fatherOfBlocks, gzeon, horsefacts, pedroais, shenwilly
16.2035 USDC - $16.20
Judge has assessed an item in Issue #20 as Medium risk. The relevant finding follows:
#0 - HickupHH3
2022-06-16T04:53:48Z
Change the check on minimum call value to a check to exact call value: require(msg.value == max_fill_withFee) Tranfer the excess ETH back to the caller at the end of the function. For example for buyAllAmountWithETH this would be msg.sender.transfer(msg.value - max_fill_withFee)
#1 - HickupHH3
2022-06-16T04:54:01Z
Duplicate of #15
🌟 Selected for report: IllIllI
Also found by: 0x1337, 0x1f8b, 0x4non, 0xDjango, 0xKitsune, 0xNazgul, 0xf15ers, ACai, AlleyCat, Bahurum, BouSalman, CertoraInc, Chom, Dravee, ElKu, FSchmoede, Funen, GimelSec, Hawkeye, JC, JMukesh, Kaiziron, MaratCerby, Metatron, PP1004, Picodes, Ruhum, SmartSek, StErMi, TerrierLover, UVvirus, UnusualTurtle, WatchPug, Waze, _Adam, asutorufos, berndartmueller, blackscale, blockdev, broccolirob, c3phas, catchup, cryptphi, csanuragjain, defsec, delfin454000, dipp, eccentricexit, ellahi, fatherOfBlocks, gzeon, hansfriese, horsefacts, hubble, ilan, joestakey, kebabsec, minhquanym, oyc_109, parashar, pauliax, rotcivegaf, sach1r0, sashik_eth, shenwilly, simon135, sorrynotsorry, sseefried, throttle, unforgiven, xiaoming90
52.0351 USDC - $52.04
State Variable Visibility Not SetRubiconMarket.sol(L191) - bool locked;
FixIt is best practice to explicitly set the visibility to one of internal, public, or private for state variables.