Venus Protocol Isolated Pools - BugBusters's results

Lines of code

https://github.com/code-423n4/2023-05-venus/blob/8be784ed9752b80e6f1b8b781e2e6251748d0d7e/contracts/RiskFund/RiskFund.sol#L265

Vulnerability details

Impact

Setting the deadline parameter in a pancake swap transaction to the block.timestamp value can have significant implications for the success of the transaction. Here are impacts:

1.Risk of Transaction Failure: Setting the deadline to the current block timestamp may not provide sufficient time for the transaction to be executed, especially during times of high network congestion. If the transaction is not executed within the specified deadline, it will be considered invalid and reverted, causing the user to lose any gas fees paid for the transaction.

2.Front-Running: When the deadline is set to the current block timestamp, it gives front-runners an opportunity to observe the pending transaction and execute a similar transaction with a higher gas fee, and delaying the user transaction and it will fail.

Proof of Concept

                    uint256[] memory amounts = IPancakeswapV2Router(pancakeSwapRouter).swapExactTokensForTokens(
                        balanceOfUnderlyingAsset,
                        amountOutMin,
                        path,
                        address(this),
                        block.timestamp
                    );

Tools Used

Manual review

Recommended Mitigation Steps

Allow the user who calling the swapPoolAssets function to also specify the moderate deadline in the params and pass that to pancake swap swapExactTokensForTokens function .

Assessed type

Other