ENS - Chom's results

Decentralized naming for wallets, websites, & more.

General Information

Platform: Code4rena

Start Date: 05/10/2023

Pot Size: $33,050 USDC

Total HM: 1

Participants: 54

Period: 6 days

Judge: hansfriese

Id: 294

League: ETH

ENS

Findings Distribution

Researcher Performance

Rank: 49/54

Findings: 1

Award: $5.43

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

5.4311 USDC - $5.43

Labels

bug
grade-b
QA (Quality Assurance)
sufficient quality report
Q-03

External Links

Missing interface IERC20MultiDelegate

There should be an IERC20MultiDelegate interface that developer can use to integrate with their smart contract without having to import the entire contract.

Missing specific ERC165 supportsInterface

ERC20MultiDelegate should override ERC165 supportsInterface to support IERC20MultiDelegate interface outlined above.

Approval may be depleted if delegating and undelegating repeatedly

contract ERC20ProxyDelegator {
    constructor(ERC20Votes _token, address _delegate) {
        _token.approve(msg.sender, type(uint256).max);
        _token.delegate(_delegate);
    }
}

Only type(uint256).max tokens are approved to ERC20MultiDelegate, so if we delegate and undelegated so many times it may be depleted causing subsequent undelegation to be reverted.

#0 - 141345

2023-10-13T08:56:09Z

Approval may be depleted if delegating and undelegating repeatedly

dup of https://github.com/code-423n4/2023-10-ens-findings/issues/294

#1 - c4-pre-sort

2023-10-13T08:59:57Z

141345 marked the issue as sufficient quality report

#2 - c4-judge

2023-10-24T16:02:59Z

hansfriese marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter