Platform: Code4rena
Start Date: 09/12/2022
Pot Size: $90,500 USDC
Total HM: 35
Participants: 84
Period: 7 days
Judge: GalloDaSballo
Total Solo HM: 12
Id: 192
League: ETH
Rank: 56/84
Findings: 1
Award: $118.88
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: Aymen0909, Deekshith99, Faith, JC, ReyAdmirado, c3phas
118.8771 USDC - $118.88
There are 4 instance of it
1st instance in the Trading.sol in the Fees struct there instead of uint we can use uint128 for saving it for 2 slot https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/Trading.sol#L98-L103
2nd instance is on https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/interfaces/IPosition.sol#L7-L20
3rd is on here bool can be written under the address https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/interfaces/IPosition.sol#L7-L20
4th is on here also bool can written under the addres to save 1 slot https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/interfaces/IPosition.sol#L22-L33
#0 - GalloDaSballo
2022-12-27T01:17:15Z
###Â 1st instance in the Trading.sol in the Fees struct All are read at same time, so it will save reading 2 slots
4.2k
Unclear, skipping
2.1k
2.1k
8400
#1 - c4-sponsor
2023-01-09T18:32:16Z
GainsGoblin marked the issue as sponsor confirmed
#2 - c4-judge
2023-01-23T08:04:12Z
GalloDaSballo marked the issue as grade-b
#3 - GalloDaSballo
2023-01-23T08:04:27Z
Simple report, high impact, barely made it, good start!
#4 - GalloDaSballo
2023-01-26T11:58:47Z
In contrast to other reports, I chose to award a B to this one despite it "mathematically falling short" because of the conciseness and value of each individual reports.
Going forward I recommend more wardens focus on High Impact Findings which will ultimately produce better reports for everyone