InsureDAO contest - Fitraldys's results

Handle

Fitraldys

Vulnerability details

Impact

When a user want to withdraw funds, the user can make a request withdrawal by calling requestWithdraw, however when doing the actual withdraw, the withdraw function memory pointer instead of storage pointer, this makes https://github.com/code-423n4/2022-01-insure/blob/main/contracts/CDSTemplate.sol#L230 changes on request.amount didnt change the actual state/storage of the withdrawalReq, therefore the request.amount is still the same as before calling the withdraw function.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/CDSTemplate.sol#L203 https://github.com/code-423n4/2022-01-insure/blob/main/contracts/CDSTemplate.sol#L230

Recommended Mitigation Steps

by changing the memory pointer to storage, not only solve this issue but also can save some small amount of gas

Handle

Fitraldys

Vulnerability details

Impact

In the https://github.com/code-423n4/2022-01-insure/blob/main/contracts/CDSTemplate.sol#L157 it is the descriptionof the depoist function, and not the correct description for the fund function.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/CDSTemplate.sol#L156-L173

Handle

Fitraldys

Vulnerability details

Impact

in line https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L260 have two check inside the require which is marketStatus == MarketStatus.Trading and paused == false and by spliting this check we can save gas.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L260

function woi() public {

        require(
            marketStatus == MarketStatus.Trading && paused == false,
            "ERROR: DEPOSIT_DISABLED"
        );

    }
// 23645 gas

can be change to

function woi() public{ 

        require(
            marketStatus == MarketStatus.Trading, "ERROR: DEPOSIT_DISABLED"
        );
        require(  
            paused == false, "ERROR: DEPOSIT_DISABLED"
        );

    }
//23637 gas

Handle

Fitraldys

Vulnerability details

Impact

in line https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L508 instead of save Insurance value to memory then save to insurences storage it's better to save the Insurence value directly to insurences storage or mapping to save gas.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L508

contract insur {

    struct Insurance {
        uint256 id; //each insuance has their own id
        uint256 startTime; //timestamp of starttime
        uint256 endTime; //timestamp of endtime
        uint256 amount; //insured amount
        bytes32 target; //target id in bytes32
        address insured; //the address holds the right to get insured
        bool status; //true if insurance is not expired or redeemed
    }

     mapping(uint256 => Insurance) public insurances;

    function coba() public {

        uint256 _id = 10;
        uint256 _endTime = 10;
        uint256 _amount = 12;
        bytes32 _target = bytes32(uint256(10));


        Insurance memory _insurance = Insurance(
            _id,
            block.timestamp,
            _endTime,
            _amount,
            _target,
            msg.sender,
            true
        );
        insurances[_id] = _insurance;

    }
}
//154623 gas

change to :

contract insur {

    struct Insurance {
        uint256 id; //each insuance has their own id
        uint256 startTime; //timestamp of starttime
        uint256 endTime; //timestamp of endtime
        uint256 amount; //insured amount
        bytes32 target; //target id in bytes32
        address insured; //the address holds the right to get insured
        bool status; //true if insurance is not expired or redeemed
    }

     mapping(uint256 => Insurance) public insurances;

    function coba() public {

        uint256 _id = 10;
        uint256 _endTime = 10;
        uint256 _amount = 12;
        bytes32 _target = bytes32(uint256(10));


        insurances[_id] = Insurance(
            _id,
            block.timestamp,
            _endTime,
            _amount,
            _target,
            msg.sender,
            true
        );
        

    }
}
//154610 gas 

Tools Used

remix

Handle

Fitraldys

Vulnerability details

Impact

in line https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L685 the function emitted a MarketStatusChanged event with storage variable which is marketStatus. when we emit an event using storage data is more expensive than emitted an event using MarketStatus.Payingout value.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L685

contract emitstatust {

    enum MarketStatus {
        Trading,
        Payingout
    }
    MarketStatus public marketStatus;

    event MarketStatusChanged(MarketStatus statusValue);

    function amit() public {
    
    marketStatus = MarketStatus.Payingout;

    emit MarketStatusChanged(marketStatus);

    }
}
//44792 gas

can change to :

contract emitstatust {

    enum MarketStatus {
        Trading,
        Payingout
    }
    MarketStatus public marketStatus;

    event MarketStatusChanged(MarketStatus statusValue);

    function amit() public {
    
    marketStatus = MarketStatus.Payingout;

    emit MarketStatusChanged(MarketStatus.Payingout);

    }
}
//44659 gas

Tools Used

remix

Handle

Fitraldys

Vulnerability details

Impact

in line https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L232 change public to external can save gas

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/PoolTemplate.sol#L232

contract test4 {

uint256 public counter = 1;

    function okelah (uint256 _amount) public {

        counter += _amount;
        require(_amount != 0, "ERROR: DEPOSIT_ZERO");

    }
}
//26836 gas

can change to

contract test4 {

uint256 public counter = 1;

    function okelah (uint256 _amount) external {

        counter += _amount;
        require(_amount != 0, "ERROR: DEPOSIT_ZERO");

    }
}
//26835 gas

Tools Used

Remix