Platform: Code4rena
Start Date: 21/06/2022
Pot Size: $55,000 USDC
Total HM: 29
Participants: 88
Period: 5 days
Judge: gzeon
Total Solo HM: 7
Id: 134
League: ETH
Rank: 57/88
Findings: 2
Award: $126.40
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: defsec
Also found by: 0x1f8b, 0x29A, 0xDjango, 0xNazgul, 0xNineDec, 0xf15ers, 0xkowloon, 0xmint, Bnke0x0, BowTiedWardens, Chom, ElKu, Funen, GalloDaSballo, GimelSec, IllIllI, JC, Kenshin, Kulk0, Lambda, Limbooo, MadWookie, Metatron, Picodes, Soosh, StErMi, TomJ, WatchPug, Waze, Yiko, _Adam, ak1, asutorufos, aysha, bardamu, catchup, datapunk, delfin454000, dipp, fatherOfBlocks, grGred, hake, hansfriese, hyh, joestakey, kebabsec, kenzo, kirk-baird, oyc_109, pashov, poirots, rfa, robee, saian, sashik_eth, shenwilly, simon135, slywaters, z3s, zeesaw, zer0dot
63.9425 USDC - $63.94
The one that correct was @return and the code was return to lent. Occurances below It can be changed.
Manual Review
1.) File : Lender.sol Lines.316
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.366
uint256 purchased;
2.) File : Lender.sol Lines.376
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.419
return returned;
3.) File : Lender.sol Lines.376
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.419
return returned;
4.) File : Lender.sol Lines.485
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.485
return returned;
5.) File : Lender.sol Lines.544
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.588
return returned;
6.) File : Lender.sol Lines.596
/// @return uint256 the amount of principal tokens lent out
File : Lender.sol Lines.631
return returned;
/// @return uint256 the amount of tokens sent to the yield pool
File : Lender.sol Lines.656
return returned;
1.) File : MarketPlace.sol Line.100
revert Exists('Market already exists');
2.) File : MarketPlace.sol Line.125
revert Exists('pool already exists');
3.) File : Lender.sol Line.83
revert Invalid('principal');
1.) File : MarketPlace.sol Line.201
avaialable to available
zeroth to zero
3.) File : Lender.sol Line.83
unsighed to unsigned
4.) File : Lender.sol Line.560
APWINE to APWine
5.) File : Lender.sol Line.175
ERC interface to ERC5095
This can be remain to be changed or deleted to avoid unnecessary comment when deployment happen
1.) File : MarketPlace.sol Line.62
(which is added here)
2.) File : Lender.sol Line.175
//use safe transfer lib and ERC interface...
3.) File : Lender.sol Line.177
//use ERC5095 interface...
4.) File : Lender.sol Line.83
// uses yield token interface...
🌟 Selected for report: BowTiedWardens
Also found by: 0v3rf10w, 0x1f8b, 0x29A, 0xKitsune, 0xNazgul, 0xf15ers, 0xkatana, 0xkowloon, Bnke0x0, ElKu, Fitraldys, Funen, GalloDaSballo, IllIllI, JC, Kaiziron, Lambda, MadWookie, Noah3o6, Nyamcil, RoiEvenHaim, TomJ, Tomio, UnusualTurtle, Waze, _Adam, ajtra, asutorufos, bardamu, c3phas, catchup, datapunk, defsec, delfin454000, fatherOfBlocks, grGred, hake, hansfriese, hyh, ignacio, joestakey, kebabsec, ladboy233, oyc_109, pashov, poirots, rfa, robee, sach1r0, samruna, sashik_eth, simon135, slywaters, z3s, zer0dot
62.4602 USDC - $62.46
++i than i++ for cost less gas1.) File : Lender.sol Lines.95-97
unchecked { i++; }
2.) File : Lender.sol Lines.119-121
unchecked { i++; }
3.) File : Lender.sol Lines.288-290
unchecked { i++; }
1.) File : Redeemer.sol Line.27
address public swivelAddr;
2.) File : Redeemer.sol Line.27
address public apwineAddr;