Asymmetry contest - Gde's results

Empty Event

The Rebalanced event has no parameters in it to emit anything. Consider adding parameters or removing it.

event Rebalanced();

Declared here: SafEth.sol#L34

Used here: SafEth.sol#L154

Events Associated With Setter/Update Functions

Consider having events associated with setter/update functions emit both the new and old values instead of just the new value.

SafEth.sol#L216

emit ChangeMinAmount(minAmount);

SafEth.sol#L225

emit ChangeMaxAmount(maxAmount);

SafEth.sol#L207

emit SetMaxSlippage(_derivativeIndex, _slippage);

SafEth.sol#L174

emit WeightChange(_derivativeIndex, _weight);

Duplicated code that could be factorized

In SfrxEth.sol, at several places we use:

IERC20(SFRX_ETH_ADDRESS).balanceOf(address(this));

SfrxEth.sol#L98
SfrxEth.sol#L102

Whereas we could just reuse the public balance() method:
SfrxEth.sol#L122-L124

In Reth.sol

We duplicate lines to get the reth token address at different places:
Reth.sol#L187-L193
Reth.sol#L229-L235

We could just reuse rethAdress() defined here: Reth.sol#L66

Lock pragmas to specific compiler version

All the files are using an unlocked compiler version.

pragma solidity ^0.8.13;

Locking the pragma helps ensure that contracts do not accidentally get deployed using, for example, the latest compiler which may have higher risks of undiscovered bugs. Contracts may also be deployed by others and the pragma indicates the compiler version intended by the original authors. It is recommended to fix a concrete compiler version (latest without security issues).

Unused Function Parameters

Unused function parameters should be commented out to avoid warning when compiling files.

SfrxEth.sol#L111

WstEth.sol#L86

Exemple refactored:

function ethPerDerivative(
        uint256 /**_amount**/
) public view returns (uint256) {