Decent - GeekyLumberjack's results

Decent enables one-click transactions using any token across chains.

General Information

Platform: Code4rena

Start Date: 19/01/2024

Pot Size: $36,500 USDC

Total HM: 9

Participants: 113

Period: 3 days

Judge: 0xsomeone

Id: 322

League: ETH

Decent

Findings Distribution

Researcher Performance

Rank: 84/113

Findings: 1

Award: $0.12

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DcntEth.sol#L20-L22 https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DcntEth.sol#L23-L26 https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DecentEthRouter.sol#L284-L299

Vulnerability details

Impact

The setRouter function is not protected in DcntEth.sol which can allow DecentEthRouter.sol to be drained

Proof of Concept

  1. Malicious contract calls setRouter and sets it to itself https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DcntEth.sol#L20C3-L22C6
  2. Malicious contract can now call the mint function and mint to itself https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DcntEth.sol#L23C1-L26C6
  3. Malicious contract can use minted tokens to drain DecentEthRouter.sol of all WETH and ETH using the redeemEth and redeemWeth functions https://github.com/decentxyz/decent-bridge/blob/7f90fd4489551b69c20d11eeecb17a3f564afb18/src/DecentEthRouter.sol#L284C4-L299C6

Tools Used

Manual Review

Protect setRouter with the onlyOwner modifier

Assessed type

Access Control

#0 - c4-pre-sort

2024-01-23T23:28:25Z

raymondfam marked the issue as sufficient quality report

#1 - c4-pre-sort

2024-01-23T23:28:32Z

raymondfam marked the issue as duplicate of #14

#2 - c4-judge

2024-02-03T13:29:35Z

alex-ppg marked the issue as satisfactory

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter