Ethereum Credit Guild - Giorgio's results

Lines of code

https://github.com/code-423n4/2023-12-ethereumcreditguild/blob/2376d9af792584e3d15ec9c32578daa33bb56b43/src/tokens/GuildToken.sol#L197-L200

Vulnerability details

Impact

The GuildToken is supposed to registers the losses of the different gauges through the ProfitManager. There is one ProfitManager per market(credit token). The protocol intends to have several markets, however can only have one ProfitManager at a time.

/// @notice reference to ProfitManager address public profitManager;

This shortcoming will severely restrict the protocol breadth and only allow for one market to be operated, instead of several.

Proof of Concept

Tools Used

Recommended Mitigation Steps

Use a mapping for registering different ProfitManager that are allowed to report to the GuildToken such as: mapping(address => bool) public isProfitManagers;

The function for add/remove a ProfitManger needs to be implemented as well.

function setManager(address profitManager, bool allowed) external role { isProfitManager[profitManager] = allowed; }

Now functions that rely on ProfitManagers need to be changed accordingly as well. To do so, associating a gauge to a profit in a mapping will make it easy to access the relevant ``profit. mapping(address => address) public gaugeToProfit;`

function _incrementGaugeWeight( address user, address gauge, uint256 weight ) internal override { address profitManager = gaugeToProfit[gauge]; . . .

Assessed type

Other