PoolTogether TwabRewards contest - Jujic's results

Handle

Jujic

Vulnerability details

Impact

Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition has been met.

Proof of Concept

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L177

Tools Used

https://planetcalc.com/9029/

Recommended Mitigation Steps

Shorten the revert strings to fit in 32 bytes.

Handle

Jujic

Vulnerability details

Impact

Here you could use unchecked{++index} to save gas since it is more efficient then index++.

Proof of Concept

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L172

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L217

Tools Used

Recommended Mitigation Steps

Handle

Jujic

Vulnerability details

Impact

The require statement in the `cancelPromotion()' method can be placed earlier to reduce gas usage on revert

Proof of Concept

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L128

L128: can be placed at the very top of the function

Tools Used

Recommended Mitigation Steps

Relocate the said require statement