RabbitHole Quest Protocol contest - Lotus's results

A protocol to distribute token rewards for completing on-chain tasks.

General Information

Platform: Code4rena

Start Date: 25/01/2023

Pot Size: $36,500 USDC

Total HM: 11

Participants: 173

Period: 5 days

Judge: kirk-baird

Total Solo HM: 1

Id: 208

League: ETH

RabbitHole

Findings Distribution

Researcher Performance

Rank: 171/173

Findings: 1

Award: $0.75

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/Erc20Quest.sol#L102

Vulnerability details

Impact

Erc20Quest.withdrawFee withdraw the protocolFee to protocolFeeRecipient. onlyAdminWithdrawAfterEnd prevents people from calling the method before the time end but anybody can call this method any amount of time. Someone could call withdrawFee multiple time and reduce the rewardToken until there's not enough for participants.

Proof of Concept

https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/Erc20Quest.sol#L102

Tools Used

Suggest to add more check to make sure only some people can execute the method.

#0 - c4-judge

2023-02-05T06:11:41Z

kirk-baird marked the issue as duplicate of #23

#1 - c4-judge

2023-02-14T08:54:38Z

kirk-baird changed the severity to 3 (High Risk)

#2 - c4-judge

2023-02-14T08:56:55Z

kirk-baird marked the issue as selected for report

#3 - c4-judge

2023-02-14T08:57:04Z

kirk-baird marked the issue as satisfactory

#4 - c4-judge

2023-02-14T08:57:29Z

kirk-baird marked the issue as not selected for report

#5 - c4-judge

2023-02-20T09:30:42Z

kirk-baird marked the issue as duplicate of #605

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter