AI Arena - OMEN's results

Lines of code

https://github.com/code-423n4/2024-02-ai-arena/blob/cd1a0e6d1b40168657d1aaee8223dc050e15f8cc/src/FighterFarm.sol#L233-L262

Vulnerability details

Impact

Lack of checking that array in fighter type param will cause unintented behaviour

Proof of Concept

  function redeemMintPass(
    uint256[] calldata mintpassIdsToBurn,
    uint8[] calldata fighterTypes,
    uint8[] calldata iconsTypes,
    string[] calldata mintPassDnas,
    string[] calldata modelHashes,
    string[] calldata modelTypes
) 
    external 
{
    require(
        mintpassIdsToBurn.length == mintPassDnas.length && 
        mintPassDnas.length == fighterTypes.length && 
        fighterTypes.length == modelHashes.length &&
        modelHashes.length == modelTypes.length
    );

Protocol implement that there is only two types of fighters . When redeem mint pass , user can which fighter types they want , And protocol check that input fighters types should be 0 or 1 . When user set fighter types to 3 , this will get them fighter 0 ,This will be unintended behaviour for users.

Tools Used

manual view

Recommended Mitigation Steps

pls make sure to check fighter types are only allowed for 0 and 1

Assessed type

DoS