InsureDAO contest - OriDabush's results

Handle

OriDabush

Vulnerability details

in some loops in the smart contracts the loops look like this:

for (uint256 i = 0; i < _ids.length; i++) { ... }

It can be turned to this instead to save some gas while incrementing i:

for (uint256 i = 0; i < _ids.length; ++i) { ... }

Some example for these loops are in:

• contracts/PoolTemplate.sol in lines 343, 671 and 703
• contracts/IndexTemplate.sol in lines 280, 348, 381, 462 and 655
• contracts/Factory.sol in lines 176 and 186

Handle

OriDabush

Vulnerability details

There is no need to write expressions like <boolean expression> == true or <boolean expression> == false, because if it is a boolean expression it will be resolved to true or false directly, and you can use it straight like this or use the not operator (!) in order to require the opposite expression.

For example, in line 165 there is the following require:

require(
            templates[address(_template)].approval == true,
            "ERROR: UNAUTHORIZED_TEMPLATE"
);

It can be replaced with the following code in order to save the comparison (==):

require(
            templates[address(_template)].approval,
            "ERROR: UNAUTHORIZED_TEMPLATE"
);

Another example for it is in line 169. The following code:

if (templates[address(_template)].isOpen == false) {
        require(
                ownership.owner() == msg.sender,
                "ERROR: UNAUTHORIZED_SENDER"
        );
}

can be replaced with this code:

if (!(templates[address(_template)].isOpen)) {
        require(
                ownership.owner() == msg.sender,
                "ERROR: UNAUTHORIZED_SENDER"
        );
}

Handle

OriDabush

Vulnerability details

Vault.sol

In the loop in lines 109-113 you can unroll the loop in order to save creating the i variable and incrementing it.

code before:

for (uint128 i = 0; i < 2; i++) {
            uint256 _allocation = (_shares[i] * _attributions) / MAGIC_SCALE_1E6;
            attributions[_beneficiaries[i]] += _allocation;
            _allocations[i] = _allocation;
}

code after:

uint256 _allocation = (_shares[0] * _attributions) / MAGIC_SCALE_1E6;
attributions[_beneficiaries[0]] += _allocation;
_allocations[0] = _allocation;

_allocation = (_shares[1] * _attributions) / MAGIC_SCALE_1E6;
attributions[_beneficiaries[1]] += _allocation;
_allocations[1] = _allocation;