Frankencoin - PNS's results

Lines of code

https://github.com/code-423n4/2023-04-frankencoin/blob/1022cb106919fba963a89205d3b90bf62543f68f/contracts/Equity.sol#L313

Vulnerability details

Impact

According to the description, the restructureCapTable should wipe all addresses given in addressesToWipe, the current implementation is based only on the first one in the array. The shares will not be burned well.

Proof of Concept

--- a/original.md
+++ b/modified.md
@@ -3,7 +3,7 @@ File: contracts/Equity.sol
 310:         require(zchf.equity() < MINIMUM_EQUITY);
 311:         checkQualified(msg.sender, helpers);
 312:         for (uint256 i = 0; i<addressesToWipe.length; i++){
-313:             address current = addressesToWipe[0];
+313:             address current = addressesToWipe[i];
 314:             _burn(current, balanceOf(current));
 315:         }
 316:     }

Recommended Mitigation Steps

It should be changed as indicated in the diff above.