Livepeer Onchain Treasury Upgrade - ReyAdmirado's results

1. state variables should be cached in stack variables rather than re-reading them from storage

The instances below point to the second+ access of a state variable within a function. Caching of a state variable replace each Gwarmaccess (100 gas) with a much cheaper stack read. Other less obvious fixes/optimizations include having local memory caches of state variable structs, or having local caches of state variable contracts/addresses.

before assigning nextRoundTotalActiveStake value to currentRoundTotalActiveStake we should cache it so we can use the cached version in #L471. this will result in 97 gas save

• BondingManager.sol#L471

2. Add unchecked {} for subtractions where the operands cannot underflow because of a previous require() or if statement

require(a <= b); x = b - a => require(a <= b); unchecked { x = b - a } if(a <= b); x = b - a => if(a <= b); unchecked { x = b - a } this will stop the check for overflow and underflow so it will save gas

the sub function exactly does the same thing

possibility checked in #L281

• BondingManager.sol#L282

penalty is a percentage of del.bondedAmount so it doessnt underflow

• BondingManager.sol#L411
• BondingManager.sol#L415

pssibility checked in #L755

• BondingManager.sol#L767

3. using bool for storage incurs overhead

Booleans are more expensive than uint256 or any type that takes up a full word because each write operation emits an extra SLOAD to first read the slot's contents, replace the bits taken up by the boolean, and then write back. This is the compiler's defense against contract upgrades and pointer aliasing, and it cannot be disabled. Use uint256(1) and uint256(2) for true/false to avoid a Gwarmaccess (100 gas) for the extra SLOAD, and to avoid Gsset (20000 gas) when changing from ‘false’ to ‘true’, after having been ‘true’ in the past

• GovernorCountingOverridable.sol#L38

4. require() Should Be Used Instead Of assert()

require() is cheaper than assert() but it provides the same functionality here

• SortedArrays.sol#L41