Sherlock contest - Ruhum's results

Handle

Ruhum

Vulnerability details

Impact

A state variable shouldn't be read multiple times within the same function. Instead, read it once and save it to memory. If the variable was modified, save it to storage at the end of the function.

That will use less gas than working with the state variable directly.

Proof of Concept

A good example is the following function: https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/managers/SherDistributionManager.sol#L90

Multiple state variables are read more than once. They are never modified. So simply saving them to memory and working with that will be way cheaper.