Platform: Code4rena
Start Date: 24/02/2022
Pot Size: $75,000 USDC
Total HM: 21
Participants: 28
Period: 7 days
Judge: alcueca
Total Solo HM: 15
Id: 94
League: ETH
Rank: 27/28
Findings: 1
Award: $181.02
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: leastwood
Also found by: 0x1f8b, 0xliumin, 0xwags, CertoraInc, Dravee, IllIllI, Ruhum, TerrierLover, WatchPug, cmichel, csanuragjain, defsec, gzeon, hubble, jayjonah8, kenta, kirk-baird, rfa, robee
181.0202 USDC - $181.02
Just one small thing I've noticed
The codebase uses custom errors. Those were introduced in Solidity 0.8.4. But most contracts
use ^0.8.0. Instead, it should be ^0.8.4 since you can't compile them with anything below that.
#0 - HardlyDifficult
2022-03-03T11:58:32Z
This is a valid point. I went back and double checked, our main repository would need >= 0.8.12 in order to compile due to the use of string.concat (but that file is not in the contest repo).
We are not going to make this change just to ease the dev process. Updating the pragma when we take advantage of a new feature causes a large diff and that noise can make it harder to notice real changes we should be paying attention to.
We pin the compiler version in the hardhat config file.
This should be revisited if we were to open up in a way where other teams are importing our contracts to develop their own extensions.
#1 - alcueca
2022-03-17T09:29:18Z
Unadjusted score: 10