SIZE contest - Sathish9098's results

1. IF THE OPERATOR IS "||" NO NEED TO CHECK MULTIPLE CONDITIONS. IF FIRST CONDITION IS TRUE THEN CAN SKIP REMAINING CONDITION CHECKS. IF CONDITION IS FALSE THEN ONLY NEED TO CHECK NEXT NEXT CONDITIONS.

Saves at least 17 gas per skipped conditions

There are 4 instances of this issue:

File : 2022-11-size/src/util/ECCMath.sol

27 : if (scalar == 0 || (point.x == 0 && point.y == 0)) return Point(1, 1);

File : 2022-11-size/src/SizeSealed.sol

144: if (quoteAmount == 0 || quoteAmount == type(uint128).max || quoteAmount < a.params.minimumBidQuote) {

187: if (pubKey.x != a.params.pubKey.x || pubKey.y != a.params.pubKey.y || (pubKey.x == 1 && pubKey.y == 1)) {

426: if (a.data.lowestQuote != type(uint128).max || block.timestamp <= a.timings.endTimestamp + 24 hours) {

---

2. ++i COSTS LESS GAS THAN i++, ESPECIALLY WHEN IT’S USED IN FOR-LOOPS (--i/i-- TOO)

File : 2022-11-size/src/SizeSealed.sol

There are 2 instances of this issue:

302: for (uint256 i; i < bidIndices.length; i++) {

244: for (uint256 i; i < seenBidMap.length - 1; i++) {

---

3. FOR "&&" OPERATORS IF FIRST CONDITION FALSE THEN NO NEED TO CHECK REMAINING CONDITIONS. && OPERATOR IF ANY ONE CONDITION FALSE THEN OVER ALL CONDITIONS BECOME FALSE. NEED TO CHECK NEXT NEXT CONDTIONS ONLY AFTER PREVIOUS CONDITION IS TRUE

File : 2022-11-size/src/SizeSealed.sol

258: if (sharedPoint.x == 1 && sharedPoint.y == 1) continue;

---

4. INSTEAD OF += OPERATOR CAN USE NORMAL ADDITION OPERATORE LIKE data.filledBase=data.filledBase+ baseAmount . += OPERATOR CONSUMES MORE GAS FEE COMPARE TO NORMAL + OPERATOR

File : 2022-11-size/src/SizeSealed.sol

294: data.filledBase += baseAmount;

---

5. NEED TO DECLARE ALL EVENT PARAMETERS AS "indexed " . SO CAN REDUCE LARGE VOLUME OF THE GAS FEE

File : 2022-11-size/src/interfaces/ISizeSealed.sol

There are 8 instances of this issue:

97 : event AuctionCreated( uint256 auctionId, address seller, AuctionParameters params, Timings timings, bytes encryptedPrivKey );

101 : event AuctionCancelled(uint256 auctionId);

103 : event Bid( address sender, uint256 auctionId, uint256 bidIndex, uint128 quoteAmount, bytes32 commitment, ECCMath.Point pubKey, bytes32 encryptedMessage, bytes encryptedPrivateKey );

114: event BidCancelled(uint256 auctionId, uint256 bidIndex);

116: event RevealedKey(uint256 auctionId, uint256 privateKey);

118: event AuctionFinalized(uint256 auctionId, uint256[] bidIndices, uint256 filledBase, uint256 filledQuote);

120: event BidRefund(uint256 auctionId, uint256 bidIndex);

122: event Withdrawal(uint256 auctionId, uint256 bidIndex, uint256 withdrawAmount, uint256 remainingAmount);

6. ERC20(auctionParams.baseToken) SHOULD BE CATCHED WITH LOCAL address VARIABLE

File : 2022-11-size/src/interfaces/ISizeSealed.sol

96 : uint256 balanceBeforeTransfer = ERC20(auctionParams.baseToken).balanceOf(address(this)); 102: uint256 balanceAfterTransfer = ERC20(auctionParams.baseToken).balanceOf(address(this)); 98 : SafeTransferLib.safeTransferFrom( ERC20(auctionParams.baseToken), msg.sender, address(this), auctionParams.totalBaseAmount );

7. USE external keyword INSTEAD public . external SAVES THE GAS USAGE COMPARE TO public

File : 2022-11-size/src/interfaces/ISizeSealed.sol

466 : function computeCommitment(bytes32 message) public pure returns (bytes32) {