Nested Finance contest - ShippooorDAO's results

This is more "a request" and not a vulnerability. This mechanism is intentional.

Agree with the sponsor that this isn't an actual vulnerability. The portfolio creator still keeps their previously accumulated fees if the fee distribution changes, its just that any new calls to _sendFees will not send as many tokens for royalties as it did before. I am going to mark this as low severity.

(Now considering as a QA report) My personal judgements:

1. "Fee distributions can be changed uniterally". I will assign this as Valid and non-critical.

Now, here is the methodology I used for calculating a score for each QA report. I first assigned each submission to be either non-critical (1 point), very-low-critical (5 points) or low-critical (10 points), depending on how severe/useful the issue is. The score of a QA report is the sum of these points, divided by the maximum number of points achieved by a QA report. This maximum number was 26 points, achieved by https://github.com/code-423n4/2022-02-nested-findings/issues/66.

The number of points achieved by this report is 1points. Thus the final score of this QA report is (1/26)*100 = 4.

Since this issue was downgraded to a QA level, and the warden did not submit a separate QA report, we've renamed this one to "QA report" for consistency.

The original title, for the record, was "Fee distributions can be changed unilaterally."

Duplicated https://github.com/code-423n4/2022-02-nested-findings/issues/15

My personal judgment: Valid and small-optimization

Now, here is the methodology I used for calculating a score for each gas report. I first assigned each submission to be either small-optimization (1 point), medium-optimization (5 points) or large-optimization (10 points), depending on how useful the optimization is. The score of a gas report is the sum of these points, divided by the maximum number of points achieved by a gas report. This maximum number was 10 points, achieved by #67.

The number of points achieved by this report is 1 points. Thus the final score of this gas report is (1/10)*100 = 10.