Velodrome Finance contest - SooYa's results

A base layer AMM on Optimism, inspired by Solidly.

General Information

Platform: Code4rena

Start Date: 23/05/2022

Pot Size: $75,000 USDC

Total HM: 23

Participants: 75

Period: 7 days

Judge: GalloDaSballo

Total Solo HM: 13

Id: 130

League: ETH

Velodrome Finance

Findings Distribution

Researcher Performance

Rank: 57/75

Findings: 1

Award: $101.23

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2022-05-velodrome/blob/main/contracts/contracts/VotingEscrow.sol#L301-L323

Vulnerability details

Impact

When using transferFrom for ERC721, _to cannot be the zero address or the caller would send their nft or token to the no one (0 address) and lost their nft or token. This could affect to transferFrom and safeTransferFrom function.

Proof of Concept

https://github.com/code-423n4/2022-05-velodrome/blob/main/contracts/contracts/VotingEscrow.sol#L301-L323

Tools Used

Manual analysis

Add require statement to chech for no zero address in _transferFrom function

#0 - GalloDaSballo

2022-06-25T21:21:42Z

QA

#1 - GalloDaSballo

2022-07-04T22:30:12Z

Low

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter