Canto v2 contest - Soosh's results

ensure() modifier - require statement is commented out

The ensure(uint deadline) modifier is used in multiple functions such as addLiquidity and removeLiquidity but the require statement is commented out, the modifier is essentially usesless.

modifier ensure(uint deadline) {
        //require(deadline >= block.timestamp, "BaseV1Router: EXPIRED");
        _;
    }

Affects Stableswap/BaseV1-periphery.sol

The code: - https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L86

Recommendations

The modifier checks if deadline has already expired. In all cases of its use, the deadline is passed as an argument to the function. Even if it is used, it can be bypassed by supplying a wrong deadline. It depends if you want to keep the ensure modifier and uncomment the require statement or outright remove it as it serves no purpose.