Decent - SovaSlava's results

Lines of code

https://github.com/code-423n4/2024-01-decent/blob/011f62059f3a0b1f3577c8ccd1140f0cf3e7bb29/src/UTB.sol#L311-L319

Vulnerability details

Impact

For make swap and execute transaction on the same chain, user should call function swapAndExecute, which have modifier retrieveAndCollectFees(). Protocol takes fee from user for swapping and execution transaction.

 function swapAndExecute(
        SwapAndExecuteInstructions calldata instructions,
        FeeStructure calldata fees,
        bytes calldata signature
    )
        public
        payable
        retrieveAndCollectFees(fees, abi.encode(instructions, fees), signature) // <----------------
    {
        _swapAndExecute(
            instructions.swapInstructions,
            instructions.target,
            instructions.paymentOperator,
            instructions.payload,
            instructions.refund
        );
    }

But, user could not pay fees and call internal function _swapAndExecute, using other external function. So, protocol will not receive a commission

Proof of Concept

User can call UTB.receiveFromBridge()

Tools Used

Manual review

Recommended Mitigation Steps

Add modifier to function receiveFromBridge with access-control, which will accept calls only from bridge contract

Assessed type

Access Control