Ajna Protocol - T1MOH's results

    function _getMinimumThresholdPercentage() internal view returns (uint256) {
        // default minimum threshold is 50
        if (_fundedExtraordinaryProposals.length == 0) {
            return 0.5 * 1e18;
        }
        // minimum threshold increases according to the number of funded EFM proposals
        else {
            return 0.5 * 1e18 + (_fundedExtraordinaryProposals.length * (0.05 * 1e18));
        }
    }

Refactor:

    function _getMinimumThresholdPercentage() internal view returns (uint256) {
        // default minimum threshold is 50
        // minimum threshold increases according to the number of funded EFM proposals
        return 0.5 * 1e18 + (_fundedExtraordinaryProposals.length * (0.05 * 1e18));
    }

[L-03] Rename StandardFunding.sol to PrimaryFunding according to the whitepaper

In whitepaper you use term "Primary Funding Mechanism" (paragraph 9.2.1). But in code that's called StandardFunding, which is confusing for new people diving into ajna-grants source code https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/base/StandardFunding.sol

Either update whitepaper or naming in StandardFunding.sol

[L-04] Use constant for constant values rather than immutable and vice versa for constant

There is a difference between constant variables and immutable variables, and they should each be used in their appropriate contexts. While it doesn’t save any gas because the compiler knows that developers often make this mistake, it’s still best to use the right tool for the task at hand.

ajna-grants/src/grants/base/StandardFunding.sol

51:    bytes32 internal constant DESCRIPTION_PREFIX_HASH_STANDARD = keccak256(bytes("Standard Funding: "));

ajna-grants/src/grants/base/Funding.sol

21:    address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079;

ajna-grants/src/grants/base/ExtraordinaryFunding.sol

28:    bytes32 internal constant DESCRIPTION_PREFIX_HASH_EXTRAORDINARY = keccak256(bytes("Extraordinary Funding: "));

#0 - c4-judge
2023-05-18T19:02:38Z

Picodes marked the issue as grade-b

Ajna Protocol - T1MOH's results

A peer to peer, oracleless, permissionless lending protocol with no governance, accepting both fungible and non fungible tokens as collateral.

General Information

Findings Distribution

Researcher Performance

External Links

[Q-34] QA Report - $36.24

Findings Information

Awards

Labels

External Links

[L-01] Keep maximum length line at 120 according to solidity style guide

[L-02] Improve readability of function _getMinimumThresholdPercentage()

[L-03] Rename StandardFunding.sol to PrimaryFunding according to the whitepaper

[L-04] Use constant for constant values rather than immutable and vice versa for constant

#0 - c4-judge2023-05-18T19:02:38Z

[L-02] Improve readability of function `_getMinimumThresholdPercentage()`

#0 - c4-judge
2023-05-18T19:02:38Z