Good Entry - T1MOH's results

pragma solidity 0.8.19;

import "forge-std/Test.sol";
import "../src/helper/V3Proxy.sol";
import "../interfaces/IUniswapV3Pool.sol";


contract V3ProxyTest is Test {

    function testB() public {
        //You can use WBTC/ETH https://info.uniswap.org/#/pools/0x4585fe77225b41b697c938b018e2ac67ac5a20c0
        //OR WBTC/DAI https://info.uniswap.org/#/pools/0x391e8501b626c623d39474afca6f9e46c2686649
        IUniswapV3Pool pool = IUniswapV3Pool(0x391E8501b626C623d39474AfcA6f9e46c2686649);

        (uint160 sqrtPriceX96,,,,,,) = pool.slot0();
    
        uint decimals0 = ERC20(pool.token0()).decimals();
        uint decimals1 = ERC20(pool.token1()).decimals();
        uint priceX8 = 10**decimals0;
        // Overflow if dont scale down the sqrtPrice before div 2*192
        priceX8 = priceX8 * uint(sqrtPriceX96 / 2 ** 12) ** 2 * 1e8 / 2**168;
        priceX8 = priceX8 / 10**decimals1;
    }
}

-   priceX8 = priceX8 * uint(sqrtPriceX96 / 2 ** 12) ** 2 * 1e8 / 2**168;
-   priceX8 = priceX8 * uint(sqrtPriceX96 / 2 ** 32) ** 2 * 1e8 / 2**128;

    function swapTokensForExactETH(uint amountOut, uint amountInMax, address[] calldata path, address to, uint deadline) payable external returns (uint[] memory amounts) {
        require(path.length == 2, "Direct swap only");
        require(path[1] == ROUTER.WETH9(), "Invalid path");
        ERC20 ogInAsset = ERC20(path[0]);
        //@audit TAKES WHOLE `amountInMax` amount
@>      ogInAsset.safeTransferFrom(msg.sender, address(this), amountInMax);
        ogInAsset.safeApprove(address(ROUTER), amountInMax);
        amounts = new uint[](2);
        amounts[0] = ROUTER.exactOutputSingle(ISwapRouter.ExactOutputSingleParams(path[0], path[1], feeTier, address(this), deadline, amountOut, amountInMax, 0));
      
        // RETURN SWAPPED ETH
        amounts[1] = amountOut; 
        ogInAsset.safeApprove(address(ROUTER), 0);
        IWETH9 weth = IWETH9(ROUTER.WETH9());
        acceptPayable = true;
        weth.withdraw(amountOut);
        acceptPayable = false;
        payable(msg.sender).call{value: amountOut}("");

@>      // DOESN'T RETURN `amountInMax - amounts[0]` AMOUNT OF ogInAsset token

        emit Swap(msg.sender, path[0], path[1], amounts[0], amounts[1]); 
    }

    function swapTokensForExactETH(uint amountOut, uint amountInMax, address[] calldata path, address to, uint deadline) payable external returns (uint[] memory amounts) {
        ...

+       ogInAsset.safeTransfer(msg.sender, amountInMax - amounts[0]);

        emit Swap(msg.sender, path[0], path[1], amounts[0], amounts[1]); 
    }

    function swapExactTokensForETH(uint amountIn, uint amountOutMin, address[] calldata path, address to, uint deadline) payable external returns (uint[] memory amounts) {
        ...

        payable(msg.sender).call{value: amounts[1]}("");
        emit Swap(msg.sender, path[0], path[1], amounts[0], amounts[1]);                 
    }

    function swapTokensForExactETH(uint amountOut, uint amountInMax, address[] calldata path, address to, uint deadline) payable external returns (uint[] memory amounts) {
        ...

        payable(msg.sender).call{value: amountOut}("");
        emit Swap(msg.sender, path[0], path[1], amounts[0], amounts[1]); 
    }

    function swapETHForExactTokens(uint amountOut, address[] calldata path, address to, uint deadline) payable external returns (uint[] memory amounts) {
        ...

        msg.sender.call{value: msg.value - amounts[0]}("");
        emit Swap(msg.sender, path[0], path[1], amounts[0], amounts[1]); 
    }

(bool success,) = payable(msg.sender).call{value: amountOut}("");
require(success, "Transfer failed");