Backd Tokenomics contest - Tadashi's results

Redundant checks can be removed

Details: The checks on L575, L589 and L602 of CrvDepositor.sol can be removed since the variables totalKeeperPoolWeight, totalLpPoolWeight and totalAmmTokenWeight are uint256 and the unchecked versions of add and sub are not used before these lines.

Some if conditions can be simplified changing ≤ to ==

Details: Some variables in the contract are of the type uint256 and will never be strictly negative. Thus, to check if these variables are not strictly positive you only need to check if they are equal to 0 — this will economize gas because EVM instruction set does not have an opcode for the condition "less than or eq", only for "less than" and "equal" opcodes.

In view of this it is suggested to perform the following simplifications:

• Since amount in L62 of AmmGauge.sol is uint256, the if condition at L63 can be simplified to

  if (amount == 0) return 0;

• Since the variables amount, crvAmount and crxAmount in L70-72 of AmmConvexGauge.sol are uint256, the if condition at L73 can be simplified to

  if (amount == 0 && crvAmount == 0 && cvxAmount == 0) return 0;

• Since the variable amount in L58 of LpGauge.sol is uint256, the if condition at L59 can be simplified to

  if (amount == 0) return 0;

Pre-incrementing a variable is cheaper than post-incrementing it

Details: Consider changing L59 and L98 of KeeperGauge.sol to ++epoch;. For more information, see G012 of c4-common-issues.

Unused library

Details: ScaledMath is added to uint256 in BkdToken.sol, but its functions are not used. Consider removing it.