OpenSea Seaport contest - Tadashi's results

A marketplace contract for safely and efficiently creating and fulfilling orders for ERC721 and ERC1155 items.

General Information

Platform: Code4rena

Start Date: 20/05/2022

Pot Size: $1,000,000 USDC

Total HM: 4

Participants: 59

Period: 14 days

Judge: leastwood

Id: 128

League: ETH

OpenSea

Findings Distribution

Researcher Performance

Rank: 55/59

Findings: 1

Award: $434.35

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository OpenSea

Findings Information

🌟 Selected for report: Dravee

Also found by: 0x1f8b, 0x29A, 0xalpharush, Chom, Czar102, Hawkeye, IllIllI, MaratCerby, MiloTruck, NoamYakov, OriDabush, RoiEvenHaim, Spearbit, Tadashi, TerrierLover, TomJ, asutorufos, cccz, cmichel, csanuragjain, defsec, delfin454000, djxploit, ellahi, foobar, gzeon, hake, hickuphh3, ignacio, ilan, joestakey, kaden, mayo, ming, oyc_109, peritoflores, rfa, sach1r0, sashik_eth, shung, sirhashalot, twojoy, zer0dot, zkhorse

Awards

434.3522 USDC - $434.35

Labels

bug

G (Gas Optimization)

External Links

Link to GitHub issue

Pre-incrementing (resp. pre-decrementing) a variable is cheaper than post-incrementing (resp. post-decrementing) it

Details: Consider the following changes to OrderCombiner.sol:

Change L229 to --maximumFulfilled;.
Change L490, L515 and L768 to ++totalFilteredExecutions;.

For more information, see G012 of c4-common-issues.

Profile: Using yarn profile the following report was obtained:

Before gas optimization

······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAdvancedOrder            ·     104014  ·     209693  ·       162960  ·          112  ·          -  │
······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAvailableAdvancedOrders  ·     173305  ·     229465  ·       205136  ·           16  ·          -  │
······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAvailableOrders          ·     172879  ·     229282  ·       206787  ·           13  ·          -  │
······························|··································|·············|·············|···············|···············|··············

After gas optimization

······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAdvancedOrder            ·     104014  ·     209631  ·       162947  ·          112  ·          -  │
······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAvailableAdvancedOrders  ·     173343  ·     229451  ·       205128  ·           16  ·          -  │
······························|··································|·············|·············|···············|···············|··············
|  Seaport                    ·  fulfillAvailableOrders          ·     172879  ·     229282  ·       206786  ·           13  ·          -  │
······························|··································|·············|·············|···············|···············|··············

OpenSea Seaport contest - Tadashi's results

A marketplace contract for safely and efficiently creating and fulfilling orders for ERC721 and ERC1155 items.

General Information

Findings Distribution

Researcher Performance

External Links

[G-41] Gas Report - $434.35

Findings Information

Awards

Labels

External Links

Pre-incrementing (resp. pre-decrementing) a variable is cheaper than post-incrementing (resp. post-decrementing) it