Platform: Code4rena
Start Date: 07/09/2022
Pot Size: $20,000 CANTO
Total HM: 7
Participants: 65
Period: 1 day
Judge: 0xean
Total Solo HM: 3
Id: 159
League: ETH
Rank: 49/65
Findings: 1
Award: $39.22
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: lukris02
Also found by: 0x040, 0x1f8b, 0x52, 0xA5DF, 0xNazgul, 0xSky, Bnke0x0, Bronicle, CertoraInc, Chom, CodingNameKiki, Deivitto, Diraco, Dravee, EthLedger, IgnacioB, JC, JansenC, Jeiwan, R2, RaymondFam, ReyAdmirado, Rolezn, SinceJuly, TomJ, Tomo, Yiko, a12jmx, ajtra, ak1, codexploder, cryptphi, csanuragjain, erictee, fatherOfBlocks, gogo, hake, hansfriese, hickuphh3, ignacio, ontofractal, oyc_109, p_crypt0, pashov, peritoflores, rajatbeladiya, rbserver, rokinot, rvierdiiev, tnevler
242.8216 CANTO - $39.22
Contract: BaseV1-core.sol
It is unnecessary to initialize variables in for loops as they get set to 0 by default in:
line 229 line 264
Recommendation:
for (uint i; i < _reserves0.length; ++i) { for (uint i; i < _totalSupplyAvg.length; ++i) {
2.
Contract: BaseV1-core.sol
It is unnecessary to initialize variables as they get set to 0 by default in:
line 244 line 245 line 277 line 278
Recommendation:
uint nextIndex; uint index;
3.
Contract: BaseV1-core.sol
There are missing spaces in the following lines of code:
line 225 line 248 line 281
Recommendation:
(uint[] memory _reserves0, uint[] memory _reserves1) = sampleReserves(granularity, 1); for(; i < lastIndex; i += window) {
All of the above will also bring consistency throughout the code of both contracts.