Platform: Code4rena
Start Date: 22/04/2021
Pot Size: $120,000 USDC
Total HM: 41
Participants: 10
Period: 7 days
Judge: LSDan
Total Solo HM: 28
Id: 5
League: ETH
Rank: 7/10
Findings: 6
Award: $3,034.83
🌟 Selected for report: 6
🚀 Solo Findings: 2
5.9395 VETH - $308.86
0.1425 ETH - $356.37
a_delamo
Here you have more info: https://gist.github.com/alexon1234/fc5600a8926944901ea58219c06b500e
#0 - strictly-scarce
2021-05-01T07:35:36Z
#1 - 0xBrian
2021-05-11T08:13:59Z
#2 - dmvt
2021-05-26T22:23:23Z
duplicate of #208
🌟 Selected for report: a_delamo
9.777 VETH - $508.40
0.2346 ETH - $586.62
a_delamo
Here you have more information: https://gist.github.com/alexon1234/e5038a9f66136ae210be692f8803d874
#0 - strictly-scarce
2021-05-01T13:17:22Z
Can't quite understand the assertion that a division is made before a multiply in the code outlined
uint _units = (((P * part1) + part2) / part3); return (_units * slipAdjustment) / one; // Divide by 10**18
_units will be 0 -> 2**256.
slipAdjustment will be 0 -> 10**18
one is 10**18
// returns 0 return (0 * 10**18) / 10**18; return (2**256 * 0) / 10**18; return (<10**9 * <10**9) / 10**18; // returns non-zero return (>=10**9 * >=10**9) / 10**18;
0 VETH - $0.00
0.0116 ETH - $29.09
a_delamo
Here you have more info: https://gist.github.com/alexon1234/f19a020f9ff1b9aae66f3805a9c9ed61
#0 - 0xBrian
2021-05-11T06:10:10Z
Not sure when this was addressed, but it's fixed now.
#1 - dmvt
2021-05-26T21:06:32Z
duplicate of #304
0 VETH - $0.00
0.0116 ETH - $29.09
a_delamo
In all the contracts we find most of the methods defined as public instead of external. Most of these methods are not being called from inside the contract, so could be defined as external and save some gas cost when being called.
Slither
Just use external when possible in order to reduce the gas cost
#0 - 0xBrian
2021-05-11T04:37:35Z
Probably addressed in mega external patch, https://github.com/vetherasset/vaderprotocol-contracts/commit/d946b6262ac83cdb7722baa3a8684c4ceabf4ea3
#1 - dmvt
2021-05-26T21:15:57Z
duplicate of #14
🌟 Selected for report: a_delamo
0 VETH - $0.00
0.0638 ETH - $159.60
a_delamo
Here you have more information: https://gist.github.com/alexon1234/b101e3ac51bea3cbd9cf06f80eaa5bc2
🌟 Selected for report: a_delamo
0 VETH - $0.00
0.0638 ETH - $159.60
a_delamo
Here you have more info: https://gist.github.com/alexon1234/5e8f4c335899a3398808bb96203bb982
🌟 Selected for report: a_delamo
0 VETH - $0.00
0.0638 ETH - $159.60
a_delamo
Here you have more information: https://gist.github.com/alexon1234/5eb3fff3bded4e4c50d6e13abae6f474
#0 - 0xBrian
2021-05-11T06:12:01Z
🌟 Selected for report: a_delamo
0 VETH - $0.00
0.0638 ETH - $159.60
a_delamo
Here you have more information: https://gist.github.com/alexon1234/4e2686497af9febae1cbc4266ad76f55
0.4276 VETH - $22.24
0.0103 ETH - $25.66
a_delamo
Here you have more info: https://gist.github.com/alexon1234/0562329c6ddd688c50a9d73d3f987a09
#0 - dmvt
2021-05-26T22:34:48Z
duplicate of #250
🌟 Selected for report: a_delamo
3.259 VETH - $169.47
0.0782 ETH - $195.54
a_delamo
Here you have more information: https://gist.github.com/alexon1234/a2d3619fb3faa4e5676329f70bd565d3
0.594 VETH - $30.89
0.0143 ETH - $35.64
a_delamo
Here you have more information: https://gist.github.com/alexon1234/2a63128fe756586700a26f02bcd2e01e
#0 - strictly-scarce
2021-05-01T07:34:33Z
Not valid.
VADER assumes the 5 anchors are listed being stablecoins, and allows anyone to swap them out if they collapse out of the median (95%). Thus they will always be stablecoins. The median price is thus the median of 5 stablecoins.
#1 - dmvt
2021-05-26T22:40:25Z
duplicate of #213
0.8799 VETH - $45.76
0.0211 ETH - $52.80
a_delamo
Here you have more details: https://gist.github.com/alexon1234/2cc60fd92ed4a9bbb0d7a864127e9941
#0 - dmvt
2021-05-26T22:31:58Z
duplicate of #12