Platform: Code4rena
Start Date: 07/04/2023
Pot Size: $47,000 USDC
Total HM: 20
Participants: 120
Period: 6 days
Judge: GalloDaSballo
Total Solo HM: 4
Id: 230
League: ETH
Rank: 120/120
Findings: 1
Award: $4.66
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: 0xLanterns
Also found by: AkshaySrivastav, Bason, CodingNameKiki, DadeKuma, DishWasher, Dug, ElKu, J4de, MiloTruck, Nyx, RaymondFam, Ruhum, T1MOH, Voyvoda, abiih, adriro, aviggiano, bshramin, sashik_eth, savi0ur, yixxas
4.6629 USDC - $4.66
Judge has assessed an item in Issue #898 as 2 risk. The relevant finding follows:
Royalty receiver will not get correct royalty as saleprice is not calculated properly https://github.com/code-423n4/2023-04-caviar/blob/main/src/EthRouter.sol#L182 uint256 salePrice = outputAmount / sells[i].tokenIds.length;
Here the salesprice for an nft is calculated by using the above formula. A user might buy different NFTs in different prices. But when above formula is used for calculating the saleprice of an NFT,the NFT may have higher price or lower price than the actual price the user paid to buy it. Due to this royalty receiver will not be receiving the actual amount that they have to receive.
#0 - c4-judge
2023-05-03T19:57:54Z
GalloDaSballo marked the issue as duplicate of #669
#1 - c4-judge
2023-05-03T19:58:15Z
GalloDaSballo marked the issue as partial-50