Dopex - alexzoid's results

Lines of code

https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/amo/UniV2LiquidityAmo.sol#L160-L178

Vulnerability details

Impact

The function _sendTokensToRdpxV2Core() in UniV2LiquidityAmo transfers tokens A and B to rdpxV2Core but doesn't synchronize the new token balances in the core contract. This could lead to inconsistencies in the state of the rdpxV2Core contract, potentially affecting subsequent operations like swaps, liquidity provision, or withdrawals.

Tools Used

Manual review

Recommended Mitigation Steps

Add a synchronization call (IRdpxV2Core(rdpxV2Core).sync();) after transferring tokens in _sendTokensToRdpxV2Core() in UniV2LiquidityAmo, similar to what's done in UniV3LiquidityAmo.

  /**
   * @dev sends token A and B to the rdpxV2Core
   */
  function _sendTokensToRdpxV2Core() internal {
    uint256 tokenABalance = IERC20WithBurn(addresses.tokenA).balanceOf(
      address(this)
    );
    uint256 tokenBBalance = IERC20WithBurn(addresses.tokenB).balanceOf(
      address(this)
    );
    // transfer token A and B from this contract to the rdpxV2Core
    IERC20WithBurn(addresses.tokenA).safeTransfer(
      addresses.rdpxV2Core,
      tokenABalance
    );
    IERC20WithBurn(addresses.tokenB).safeTransfer(
      addresses.rdpxV2Core,
      tokenBBalance
    );

    // sync token balances
    IRdpxV2Core(rdpxV2Core).sync();

    emit LogAssetsTransfered(msg.sender, tokenABalance, tokenBBalance); // @audit
  }

Assessed type

Other