Rubicon contest - antonttc's results

Low severity

offer won't work with non-standard ERC20 that doesn't return true on transferFrom

The codebase use transferFrom in functions like swap and offer and enforce a true returned to proceed. This might not work with some existing ERC20. Consider using safeERC20 as a safer and more widely adopted pattern.

Gas optimization

1. pack variables for sortInfo and OfferInfo.

Consider packing the sortInfo into a single 256 bits storage slot.

uint96 next; // should be sufficient for # of ids
uint96 prev;  //should be sufficient for # of ids
uint32 delb; // 32 bits is enough for timestamp or blockNumber

For OfferInfo, consider packing 2 amounts with the timestamp

struct OfferInfo {
    uint96 pay_amt;
    uint96 buy_amt;
    uint64 timestamp;
    ERC20 pay_gem
    ERC20 buy_gem;
    address owner;
}