LSD Network - Stakehouse contest - bearonbike's results

Lines of code

https://github.com/code-423n4/2022-11-stakehouse/blob/main/contracts/liquid-staking/LiquidStakingManager.sol#L468-L469

Vulnerability details

Impact

Accroding to the code annotation in LiquidStakingManager.registerBLSPublicKeys(), BLS public key registerd as validator should be part of LSD network and not banned, But the code does not check the BLS public key is banned or not.This will allow banned BLS public key registered as validator.

Proof of Concept

https://github.com/code-423n4/2022-11-stakehouse/blob/main/contracts/liquid-staking/LiquidStakingManager.sol#L468-L469 // check if the BLS public key is part of LSD network and is not banned require(isBLSPublicKeyPartOfLSDNetwork(_blsPublicKey) == false, "BLS public key is banned or not a part of LSD network");

Tools Used

Vscode

Recommended Mitigation Steps

Modify require condition like this: // check if the BLS public key is part of LSD network and is not banned require(isBLSPublicKeyPartOfLSDNetwork(_blsPublicKey) == false && bannedBLSPublicKeys[_blsPublicKey] == address(0), "BLS public key is banned or not a part of LSD network");