ElasticSwap contest - byterocket's results

Handle

byterocket

Vulnerability details

Impact

Issue Information: G007

Findings:

contracts/Exchange.sol::137 => "Exchange: FEE_ON_TRANSFER_NOT_SUPPORTED"
contracts/Exchange.sol::179 => "Exchange: MINS_MUST_BE_GREATER_THAN_ZERO"
contracts/ExchangeFactory.sol::44 => require(_baseToken != _quoteToken, "ExchangeFactory: IDENTICAL_TOKENS");
contracts/ExchangeFactory.sol::47 => "ExchangeFactory: INVALID_TOKEN_ADDRESS"
contracts/ExchangeFactory.sol::52 => "ExchangeFactory: DUPLICATE_EXCHANGE"
contracts/ExchangeFactory.sol::75 => "ExchangeFactory: INVAlID_FEE_ADDRESS"
libraries/MathLib.sol::267 => "MathLib: INSUFFICIENT_CHANGE_IN_DECAY"
libraries/MathLib.sol::337 => "MathLib: INSUFFICIENT_CHANGE_IN_DECAY"
libraries/MathLib.sol::497 => "MathLib: INSUFFICIENT_BASE_QTY_DESIRED"
libraries/MathLib.sol::501 => "MathLib: INSUFFICIENT_QUOTE_QTY_DESIRED"
libraries/MathLib.sol::608 => "MathLib: INSUFFICIENT_BASE_TOKEN_QTY"
libraries/MathLib.sol::641 => "MathLib: INSUFFICIENT_BASE_TOKEN_QTY"
libraries/MathLib.sol::677 => "MathLib: INSUFFICIENT_QUOTE_TOKEN_QTY"

Tools used

c4udit

Handle

byterocket

Vulnerability details

Impact

Issue Information: G003

Findings:

contracts/Exchange.sol::113 => if (tokenQtys.liquidityTokenFeeQty > 0) {
contracts/Exchange.sol::176 => require(this.totalSupply() > 0, "Exchange: INSUFFICIENT_LIQUIDITY");
contracts/Exchange.sol::178 => _baseTokenQtyMin > 0 && _quoteTokenQtyMin > 0,
contracts/Exchange.sol::235 => if (liquidityTokenFeeQty > 0) {
contracts/Exchange.sol::267 => _baseTokenQty > 0 && _minQuoteTokenQty > 0,
contracts/Exchange.sol::304 => _quoteTokenQty > 0 && _minBaseTokenQty > 0,
libraries/MathLib.sol::125 => require(_tokenAQty > 0, "MathLib: INSUFFICIENT_QTY");
libraries/MathLib.sol::127 => _tokenAReserveQty > 0 && _tokenBReserveQty > 0,
libraries/MathLib.sol::266 => baseTokenQtyDecayChange > 0,
libraries/MathLib.sol::336 => quoteTokenQtyDecayChange > 0,
libraries/MathLib.sol::347 => require(quoteTokenDecay > 0, "MathLib: NO_QUOTE_DECAY");
libraries/MathLib.sol::388 => if (_totalSupplyOfLiquidityTokens > 0) {
libraries/MathLib.sol::496 => _baseTokenQtyDesired > 0,
libraries/MathLib.sol::500 => _quoteTokenQtyDesired > 0,
libraries/MathLib.sol::606 => _baseTokenReserveQty > 0 &&
libraries/MathLib.sol::607 => _internalBalances.baseTokenReserveQty > 0,
libraries/MathLib.sol::664 => _baseTokenQty > 0 && _quoteTokenQtyMin > 0,

Tools used

c4udit

Handle

byterocket

Vulnerability details

Impact

Issue Information: G008

Findings:

libraries/MathLib.sol::43 => return ((a * WAD) + (b / 2)) / b;
libraries/MathLib.sol::55 => return ((a + (n / 2)) / n) * n;
libraries/MathLib.sol::67 => return ((a * b) + (WAD / 2)) / WAD;
libraries/MathLib.sol::85 => uint256 x = y / 2 + 1;
libraries/MathLib.sol::88 => x = (y / x + x) / 2;

Tools used

c4udit