Arcade.xyz - circlelooper's results

Lines of code

https://github.com/code-423n4/2023-07-arcade/blob/f8ac4e7c4fdea559b73d9dd5606f618d4e6c73cd/contracts/ArcadeTreasury.sol#L198

Vulnerability details

Impact

Should not reduce gscAllowance[token] when CORE_VOTING_ROLE user trys to decrease token allowance, transaction may fail otherwise.

Proof of Concept

Function gscApprove(address token, address spender, uint256 amount) can be called by CORE_VOTING_ROLE user to approve token to some other addresses.

When approve, gscAllowance[token] is reduced:

        gscAllowance[token] -= amount;

If CORE_VOTING_ROLE user gives full allowance to an address and then wants to decrease the approved allowance a little bit, transaction will fail due to math error as there is no gscAllowance[token] left.

Tools Used

Manual Review

Recommended Mitigation Steps

It's recommended not to reduce gscAllowance[token] when CORE_VOTING_ROLE user trys to decrease token allowance

Assessed type

Access Control