Paladin - Warden Pledges contest - codexploder's results

Lines of code

https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L456 https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L488

Vulnerability details

Impact

Owner can pause the contract at any time. It seems once contract is paused, Users are not even allowed to close or retrievePledgeRewards which means their funds are stuck until owner decides to unpause the contract.

Proof of Concept

1. Owner pauses the contract using pause function

function pause() external onlyOwner {
        _pause();
    }

2. All contract users cannot get back their pledge funds since both retrievePledgeRewards/closePledge will revert when contract is paused

function closePledge(uint256 pledgeId, address receiver) external whenNotPaused nonReentrant {
...
}

function retrievePledgeRewards(uint256 pledgeId, address receiver) external whenNotPaused nonReentrant {
...
}

Recommended Mitigation Steps

Remove the whenNotPaused modifier from both closePledge and retrievePledgeRewards function