Platform: Code4rena
Start Date: 21/11/2022
Pot Size: $90,500 USDC
Total HM: 18
Participants: 101
Period: 7 days
Judge: Picodes
Total Solo HM: 4
Id: 183
League: ETH
Rank: 71/101
Findings: 1
Award: $53.49
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: 0xSmartContract
Also found by: 0xAgro, 0xNazgul, 0xPanda, 0xbepresent, 0xfuje, Awesome, B2, Bnke0x0, Deivitto, Diana, Funen, Jeiwan, JohnSmith, Josiah, R2, RaymondFam, Rolezn, Sathish9098, Waze, adriro, aphak5010, brgltd, btk, carrotsmuggler, ch0bu, chaduke, codeislight, codexploder, cryptostellar5, csanuragjain, danyams, datapunk, delfin454000, deliriusz, eierina, erictee, fatherOfBlocks, gz627, gzeon, hansfriese, hihen, jadezti, joestakey, keccak123, martin, nameruse, oyc_109, pedr02b2, perseverancesuccess, rbserver, rotcivegaf, rvierdiiev, sakshamguruji, shark, simon135, subtle77, unforgiven, xiaoming90, yixxas
53.4851 USDC - $53.49
https://github.com/code-423n4/2022-11-redactedcartel/blob/main/src/PirexGmx.sol#L719 https://github.com/code-423n4/2022-11-redactedcartel/blob/main/src/PirexGmx.sol#L691
The redeem function should be free of any Pausing constraints, otherwise if owner decides to never unpause the contract then full user funds will get stuck in the contract
Owner pause the contract using setPauseState
User A wants to redeem his funds using redeemPxGlpETH/redeemPxGlp function
Both function fails since redeem does not work when contract is paused and both functions are using whenNotPaused modifier
Remove the whenNotPaused modifier from redeemPxGlpETH/redeemPxGlp function
#0 - c4-judge
2022-12-04T00:26:56Z
Picodes marked the issue as duplicate of #386
#1 - c4-judge
2022-12-21T07:46:04Z
Picodes marked the issue as not a duplicate
#2 - c4-judge
2022-12-21T07:46:14Z
Picodes changed the severity to QA (Quality Assurance)
#3 - c4-judge
2023-01-01T11:07:38Z
Picodes marked the issue as grade-b