ElasticSwap contest - csanuragjain's results

Handle

csanuragjain

Vulnerability details

Impact

Gas savings

Proof of Concept

1. Navigate to contract https://github.com/code-423n4/2022-01-elasticswap/blob/main/elasticswap/src/contracts/Exchange.sol

2. Observe that below condition is not required in swapBaseTokenForQuoteToken function as this is already checked in calculateQuoteTokenQty function of MathLib

require( _baseTokenQty > 0 && _minQuoteTokenQty > 0,  "Exchange: INSUFFICIENT_TOKEN_QTY");

3. Similarly below condition is not required in swapQuoteTokenForBaseToken function as this is already checked in calculateBaseTokenQty function of MathLib

require(
            _quoteTokenQty > 0 && _minBaseTokenQty > 0,
            "Exchange: INSUFFICIENT_TOKEN_QTY"
        );