Tigris Trade contest - csanuragjain's results

Lines of code

https://github.com/code-423n4/2022-12-tigris/blob/main/contracts/Lock.sol#L84

Vulnerability details

Impact

As confirmed from Product team, totalLocked variable is used in UI for showing stats to User. It seems that while extending the lock, this value is not updated. This means UI will show lower Locked amount than actual. All calculations of incentives based on locked amount would also be incorrect and this also impacts investors interest in locking their amount

Proof of Concept

1. Observe the extendLock function

function extendLock(
        uint _id,
        uint _amount,
        uint _period
    ) public {
        address _asset = claim(_id);
        IERC20(_asset).transferFrom(msg.sender, address(this), _amount);
        bondNFT.extendLock(_id, _asset, _amount, _period, msg.sender);
    }

2. As we can see in above code snippet the local variable totalLocked[_asset] is not updated even when lock is extended by _amount . This is also not updated in bondNFT.extendLock. This means totalLocked[_asset] will show lower value than actual

Recommended Mitigation Steps

Revise the extendLock function as below:

function extendLock(
        uint _id,
        uint _amount,
        uint _period
    ) public {
        address _asset = claim(_id);
totalLocked[_asset] += _amount;
        IERC20(_asset).transferFrom(msg.sender, address(this), _amount);
        bondNFT.extendLock(_id, _asset, _amount, _period, msg.sender);
    }